#patch: break wait loop instead of returning order read

Author: circa10a

docs/resources/order.md

@@ -23,7 +23,7 @@ Mailform order
 - `from_name` (String) The name of the sender of this envelope or postcard.
 - `from_postcode` (String) The address postcode or zip code of the sender of this envelope or postcard. Example "00000"
 - `from_state` (String) The address state of the sender of this envelope or postcard. Example "WA"
-- `service` (String) What shipping service/speed to use.
+- `service` (String) What shipping service/speed to use. Must be one of: `FEDEX_OVERNIGHT`, `USPS_PRIORITY_EXPRESS`, `USPS_PRIORITY`, `USPS_CERTIFIED_PHYSICAL_RECEIPT`, `USPS_CERTIFIED_RECEIPT`, `USPS_CERTIFIED`, `USPS_FIRST_CLASS`, `USPS_STANDARD`, `USPS_POSTCARD`
 - `to_address_1` (String) The street number and name of the recipient of this envelope or postcard.
 - `to_city` (String) The address state of the recipient of this envelope or postcard.
 - `to_country` (String) The address country of the recipient of this envelope or postcard. Example "US"

internal/provider/resource_mailform_order.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/circa10a/go-mailform"
@@ -45,7 +46,7 @@ var orderInputSchema = map[string]*schema.Schema{
 		ForceNew:    true,
 	},
 	"service": {
-		Description:  "What shipping service/speed to use.",
+		Description:  fmt.Sprintf("What shipping service/speed to use. Must be one of: `%s`", strings.Join(mailform.ServiceCodes, "`, `")),
 		Type:         schema.TypeString,
 		Required:     true,
 		ValidateFunc: validation.StringInSlice(mailform.ServiceCodes, false),
@@ -325,14 +326,16 @@ func resourceMailformOrderCreate(ctx context.Context, d *schema.ResourceData, m
 				}
 				orderStatus := order.Data.State
 				tflog.Debug(ctx, fmt.Sprintf("order state: %s", orderStatus))
-				// If order has been mailed
-				if orderStatus == mailform.StatusFulfilled {
-					return orderRead(ctx, d, m)
-				}
+
 				// If order was cancelled, break
 				if orderStatus == mailform.StatusCancelled {
 					return diag.FromErr(errOrderCancelled)
 				}
+
+				// If order has been mailed
+				if orderStatus == mailform.StatusFulfilled {
+					break
+				}
 				select {
 				case <-timer.C:
 					return diag.FromErr(errors.New("waiting for order to be fulfilled timed out"))