improve url handling

Author: circa10a

Makefile

@@ -3,7 +3,7 @@ PROVIDER_NAME=mcbroken
 PROVIDER_FULL_PATH=$(REGISTRY)/$(NAMESPACE)/$(PROVIDER_NAME)
 PROVIDER_FULL_NAME=terraform-provider-$(PROVIDER_NAME)
 PROJECT=$(NAMESPACE)/$(PROVIDER_FULL_NAME)
-VERSION=0.1.1
+VERSION=0.1.2
 
 build-mac: PLUGIN_DIR = ~/.terraform.d/plugins/local/provider/$(PROVIDER_NAME)/$(VERSION)/darwin_amd64
 build-mac:

README.md

@@ -32,26 +32,32 @@ provider "mcbroken" {}
 
 // Data source to get all available cities/national average of broken ice cream machines
 data "mcbroken_cities" "all" {}
+
 // Data source to get current outage percentage of a specific city
 data "mcbroken_city" "Dallas" {
     city = "Dallas"
 }
+
 // If specified city isn't found, returns -1
 data "mcbroken_city" "not_found" {
     city = "not_found"
 }
+
 // Get national average of broken ice cream machines
 output "global_broken_average" {
     value = data.mcbroken_cities.all.broken
 }
+
 // Get list of all cities and their outage percentage
 output "all_available_cities" {
     value = data.mcbroken_cities.all.cities
 }
+
 // Get outage percentage of a specific city
 output "user_specified_city" {
     value = data.mcbroken_city.Dallas.broken
 }
+
 // When user specified city isn't found, return -1
 output "user_specified_city_not_found" {
     value = data.mcbroken_city.not_found.broken

docs/index.md

@@ -17,26 +17,32 @@ provider "mcbroken" {}
 
 // Data resource to get all available cities/national average of broken ice cream machines
 data "mcbroken_cities" "all" {}
+
 // Data resource to get current outage percentage of a specific city
 data "mcbroken_city" "Dallas" {
     city = "Dallas"
 }
+
 // If specified city isn't found, returns -1
 data "mcbroken_city" "not_found" {
     city = "not_found"
 }
+
 // Get national average of broken ice cream machines
 output "global_broken_average" {
     value = data.mcbroken_cities.all.broken
 }
+
 // Get list of all cities and their outage percentage
 output "all_available_cities" {
     value = data.mcbroken_cities.all.cities
 }
+
 // Get outage percentage of a specific city
 output "user_specified_city" {
     value = data.mcbroken_city.Dallas.broken
 }
+
 // When user specified city isn't found, return -1
 output "user_specified_city_not_found" {
     value = data.mcbroken_city.not_found.broken

examples/main.tf

@@ -2,7 +2,6 @@ terraform {
   required_providers {
     mcbroken = {
       source  = "local/provider/mcbroken"
-      version = "0.1.1"
     }
   }
 }
@@ -11,26 +10,32 @@ provider "mcbroken" {}
 
 // Data resource to get all available cities/national average of broken ice cream machines
 data "mcbroken_cities" "all" {}
+
 // Data resource to get current outage percentage of a specific city
 data "mcbroken_city" "Dallas" {
     city = "Dallas"
 }
+
 // If specified city isn't found, returns -1
 data "mcbroken_city" "not_found" {
     city = "not_found"
 }
+
 // Get national average of broken ice cream machines
 output "global_broken_average" {
     value = data.mcbroken_cities.all.broken
 }
+
 // Get list of all cities and their outage percentage
 output "all_available_cities" {
     value = data.mcbroken_cities.all.cities
 }
+
 // Get outage percentage of a specific city
 output "user_specified_city" {
     value = data.mcbroken_city.Dallas.broken
 }
+
 // When user specified city isn't found, return -1
 output "user_specified_city_not_found" {
     value = data.mcbroken_city.not_found.broken

mcbroken/provider.go

@@ -38,7 +38,7 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}
 			Summary:  "Unable to parse url",
 			Detail:   "Mcbroken endpoint provided is not a valid url",
 		})
-
+		return nil, diags
 	}
 
 	providerConfig["url"] = mcbrokenEndpoint