Skip to content

Commit 45727f0

Browse files
committed
fix some links and update htmlproofer config to ignore private links
1 parent 63a56f6 commit 45727f0

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

.circleci/config.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,13 @@ jobs:
125125
command: |
126126
set -e
127127
echo "[INFO] Validating built site with HTML Proofer..."
128-
ls -la
129-
htmlproofer --help
130128
# Handle path prefix and ignore search template placeholders
131129
htmlproofer ./build \
132130
--ignore-empty-alt \
133131
--checks 'Links,Images' \
134132
--swap-urls '^/docs/:/' \
135133
--ignore-files './build/api/v1/index.html,./build/api/v2/index.html' \
136-
--ignore-urls '[url],[path],https://circleci.com/api/v1.1/me,https://circleci.com/docs/webhooks/#outbound-webhooks' \
134+
--ignore-urls '[url],[path],https://circleci.com/api/v1.1/me,https://circleci.com/docs/webhooks/#outbound-webhooks,.*circleci-docs-static.*' \
137135
--ignore-status-codes '403,429,999' \
138136
--no-check-external-hash \
139137
--typhoeus '{"timeout":30,"followlocation":true,"headers":{"User-Agent":"Mozilla/5.0 (compatible; LinkChecker)"}}'

docs/guides/modules/execution-managed/pages/custom-images.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ The example uses Docker Hub, but you can use different registries if you prefer.
145145
[#preparing-the-image-for-the-registry]
146146
=== 8. Prepare the image for the registry
147147
148-
. Log in to Docker Hub with your account and create a new repository on the https://hub.docker.com/add/repository/[add repository] page.
148+
. Log in to Docker Hub with your account and create a new repository on the Repositories page.
149149
It is best practice to use a pattern similar to `<project-name>-<container-name>` for a repository name (for example, `cci-demo-docker-primary`).
150150
151151
. Next, rebuild your image using your account and repository name:
@@ -199,7 +199,7 @@ NOTE: This section assumes you have already used Docker login locally.
199199
200200
This section demonstrates how to build a Ruby container to use on CircleCI.
201201
202-
The example starts with the link:https://hub.docker.com/_/ruby/[Ruby 2.1] image. However, instead of using FROM `ruby:2.1` as the base image it describes how the container is built. From the Ruby Docker Hub page, go to the link:https://raw.githubusercontent.com/docker-library/ruby/e32433a12099d96dc5a1b28a011b73af4f17cfff/2.1/Dockerfile10[2.1/Dockerfile].
202+
The example starts with the link:https://hub.docker.com/_/ruby/[Ruby 2.1] image. However, instead of using FROM `ruby:2.1` as the base image it describes how the container is built. From the Ruby Docker Hub page, go to the 2.1/Dockerfile.
203203

204204
Notice the environment variables that are used to pull in the correct versions.
205205

docs/guides/modules/permissions-authentication/pages/set-up-sso.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To begin setting up a SAML SSO connection in your CircleCI organization, follow
2222

2323
=== Configure your Identity Provider (IdP)
2424

25-
Next you will configure your IdP. The steps to do this will vary depending on your IdP. For example, if you are using Okta, refer to link:https://help.okta.com/en-us/content/topics/apps/apps_app_integration_wizard_saml.html[Okta's documentation].
25+
Next you will configure your IdP. The steps to do this will vary depending on your IdP. For example, if you are using Okta, refer to link:https://help.okta.com/[Okta's documentation].
2626

2727
. Open your IdP and paste the required configuration details (**Setup Parameters** and **Allowed iFrame Origin**) retrieved from CircleCI in the previous section to configure your IdP.
2828
. Add `https://app.circleci.com` to your IdP's trusted origins for iframe embedding. This is required to validate a user's active SSO session when they are interacting with an SSO organization in CircleCI.

0 commit comments

Comments
 (0)