Update roles-and-permissions tables #9472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added centre alignment to 'ORGANIZATION ROLES` table header
|
Hi @benNew89 , thanks for the PR. The fix is actually included in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When looking at the tables on the roles-and-permissions-overview page, the 'ORGANIZATION ROLES` header looks off. The header is left-aligned and although it looks center-aligned over the 'Admin' role, it should be center-aligned above all 3 roles
Current table layout:
Proposed change:
Reasons
The table doesn't look like it's formatted when the 'ORGANIZATION ROLES` is left aligned and the sub-headers are center aligned
How has it been tested?
No testing, but it's purely a formatting change, no content is getting changed. The changes were checked in an asciidoc editor before being applied in the branch
What other systems will this impact?
None