-
Notifications
You must be signed in to change notification settings - Fork 32
Description
File affected:
buidl-wallet-contracts/src/msca/6900/v0.8/modules/addressbook/ColdStorageAddressBookModule.sol
Line 187 in 3c47aa9
| revert Unsupported(); |
Description
The verifyAllowedTargetOrRecipient() function, intended to be invoked as a validation hook for validation modules installed on the account, reverts in case the account action is not execute() or executeBatch().
This has the unfortunate side effect of blocking calls invoking state changes to the ColdStorageAddressBookModule via account.addAllowedRecipients() and account.removeAllowedRecipients(), which is the intended flow of execution functions installed on to the account via execution modules.
Technically, these functions can still be invoked via execute(ColdStorageAddressBookModule, 0, addAllowedRecipients(addressArray) but that defies the purpose of exposing the module as an execution module.
Recommendation
Remove the revert at the end of the function in verifyAllowedTargetOrRecipient().