Skip to content

Reverting Validation Hook Blocks Possibility of Intended Invocation of Execution Module #112

@Schereo

Description

@Schereo

File affected:

Description
The verifyAllowedTargetOrRecipient() function, intended to be invoked as a validation hook for validation modules installed on the account, reverts in case the account action is not execute() or executeBatch().
This has the unfortunate side effect of blocking calls invoking state changes to the ColdStorageAddressBookModule via account.addAllowedRecipients() and account.removeAllowedRecipients(), which is the intended flow of execution functions installed on to the account via execution modules.
Technically, these functions can still be invoked via execute(ColdStorageAddressBookModule, 0, addAllowedRecipients(addressArray) but that defies the purpose of exposing the module as an execution module.

Recommendation
Remove the revert at the end of the function in verifyAllowedTargetOrRecipient().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions