Fix #7

Author: circlesabound

src/agent/factorio.rs

@@ -145,4 +145,20 @@ mod tests {
 
         Ok(())
     }
+
+    #[tokio::test]
+    async fn can_install_version_2_0_28() -> std::result::Result<(), Box<dyn std::error::Error>> {
+        fctrl::util::testing::logger_init();
+
+        let tmp_dir = std::env::temp_dir().join(Uuid::new_v4().to_string());
+        fs::create_dir(&tmp_dir).await?;
+        let mut vm = VersionManager::new(&tmp_dir).await?;
+        vm.install("2.0.28".to_owned()).await?;
+
+        assert!(vm.versions.contains_key("2.0.28"));
+
+        let _ = fs::remove_dir_all(tmp_dir).await;
+
+        Ok(())
+    }
 }

src/agent/main.rs

@@ -1030,6 +1030,28 @@ impl AgentController {
         map_settings: Option<MapSettingsJson>,
         operation_id: OperationId,
     ) {
+        // Fail if save with same name already exists
+        match util::saves::exists_savefile(&save_name).await {
+            Ok(false) => {
+                // ok
+            },
+            Ok(true) => {
+                self.reply_failed(
+                    AgentOutMessage::Error(format!("Savefile with name {} already exists", save_name)),
+                    operation_id)
+                .await;
+                return
+            },
+            Err(e) => {
+                error!("Failed to check if savefile with name {} already exists: {:?}", save_name, e);
+                self.reply_failed(
+                    AgentOutMessage::Error(format!("Failed to check if savefile with name {} already exists: {:?}", save_name, e)),
+                    operation_id)
+                .await;
+                return;
+            },
+        }
+
         // assume there is at most one version installed
         if let Ok(version_mg) =
             tokio::time::timeout(Duration::from_millis(250), self.version_manager.read()).await