Disable PIC on Windows (it breaks GHC annotations) (input-output-hk#2146)

* Disable PIC on Windows (it breaks GHC annotations)

* Disable PIC on Windows (it breaks GHC annotations)

* Disable test on ghcjs for now

* Disable broken test

Author: hamishmack

compiler/ghc/default.nix

@@ -311,8 +311,10 @@ let
       # For cross compilers only the RTS should be built with -mno-outline-atomics
       + lib.optionalString (!hostPlatform.isAarch64 && targetPlatform.isLinux && targetPlatform.isAarch64)
         " '*.rts.ghc.c.opts += -optc-mno-outline-atomics'"
-      + lib.optionalString enableRelocatedStaticLibs
+      # PIC breaks GHC annotations on windows (see test/annotations for a test case)
+      + lib.optionalString (enableRelocatedStaticLibs && !targetPlatform.isWindows)
         " '*.*.ghc.*.opts += -fPIC' '*.*.cc.*.opts += -fPIC'"
+      # `-fexternal-dynamic-refs` causes `undefined reference` errors when building GHC cross compiler for windows
       + lib.optionalString (enableRelocatedStaticLibs && targetPlatform.isx86_64 && !targetPlatform.isWindows)
         " '*.*.ghc.*.opts += -fexternal-dynamic-refs'"
       # The following is required if we build on aarch64-darwin for aarch64-iOS. Otherwise older

test/annotations/Lib.hs

@@ -0,0 +1,5 @@
+module Lib where
+
+{-# ANN module "HLint: ignore Use fmap" #-}
+
+x=1

test/annotations/cabal.project

@@ -0,0 +1 @@
+packages: .

test/annotations/default.nix

@@ -0,0 +1,20 @@
+{ stdenv, lib, util, project', haskellLib, recurseIntoAttrs, testSrc, compiler-nix-name, evalPackages }:
+
+with lib;
+
+let
+  project = project' {
+    inherit compiler-nix-name evalPackages;
+    src = testSrc "annotations";
+  };
+
+in recurseIntoAttrs {
+  meta.disabled = stdenv.hostPlatform.isGhcjs
+    # Failed to lookup symbol: __aarch64_swp8_acq_rel
+    || (builtins.elem compiler-nix-name ["ghc947" "ghc948"] && haskellLib.isCrossHost && stdenv.hostPlatform.isAarch64);
+  ifdInputs = {
+    inherit (project) plan-nix;
+  };
+
+  build = project.hsPkgs.test-annotations.components.library;
+}

test/annotations/test-annotations.cabal

@@ -0,0 +1,10 @@
+cabal-version: 1.24
+name: test-annotations
+version: 1
+build-type: Simple
+
+library
+  exposed-modules: Lib
+  hs-source-dirs: .
+  build-depends: base
+  default-language: Haskell2010

test/default.nix

@@ -217,6 +217,7 @@ let
     ca-derivations = callTest ./ca-derivations { inherit CADerivationsEnabled; };
     ca-derivations-include = callTest ./ca-derivations-include { inherit CADerivationsEnabled; };
     test-only = callTest ./test-only { inherit util; };
+    annotations = callTest ./annotations { inherit util; };
     cabal-project-nix-path = callTest ./cabal-project-nix-path {};
     plugin = callTest ./plugin {};
     unit = unitTests;