Skip to content

Commit a27a081

Browse files
authored
Merge pull request #317 from makermelissa/beta
Fix MicroPython showing busy forever
2 parents 6bea5b0 + 44d609e commit a27a081

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

js/workflows/usb.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,6 @@ class USBWorkflow extends Workflow {
124124
device = await navigator.serial.requestPort();
125125
console.log(device);
126126
}
127-
128-
// TODO: Make it more obvious to user that something happened for smaller screens
129-
// Perhaps providing checkmarks by adding a css class when a step is complete would be helpful
130-
// This would help with other workflows as well
131127
} else {
132128
console.log('Requesting any serial device...');
133129
try {
@@ -171,7 +167,7 @@ class USBWorkflow extends Workflow {
171167
btnSelectHostFolder.disabled = true;
172168
let serialConnect = async (event) => {
173169
try {
174-
await this.showBusy(this.connectToSerial());
170+
await this.connectToSerial();
175171
} catch (e) {
176172
//console.log(e);
177173
//alert(e.message);
@@ -291,7 +287,7 @@ class USBWorkflow extends Workflow {
291287

292288
// At this point we should see if we should init the file client and check if have a saved dir handle
293289
let fileops = new FileOps(this.repl, false);
294-
if (await fileops.isReadOnly()) {
290+
if (await this.showBusy(fileops.isReadOnly())) {
295291
// UID Only needed for matching the CIRCUITPY drive with the Serial Terminal
296292
await this.showBusy(this._getDeviceUid());
297293
let modal = this.connectDialog.getModal();

0 commit comments

Comments
 (0)