Skip to content

Commit c7bf52e

Browse files
authored
Merge pull request #323 from circuitpython/beta
Merge Beta
2 parents 047111a + a27a081 commit c7bf52e

File tree

7 files changed

+30
-21
lines changed

7 files changed

+30
-21
lines changed

js/workflows/usb.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,6 @@ class USBWorkflow extends Workflow {
124124
device = await navigator.serial.requestPort();
125125
console.log(device);
126126
}
127-
128-
// TODO: Make it more obvious to user that something happened for smaller screens
129-
// Perhaps providing checkmarks by adding a css class when a step is complete would be helpful
130-
// This would help with other workflows as well
131127
} else {
132128
console.log('Requesting any serial device...');
133129
try {
@@ -171,7 +167,7 @@ class USBWorkflow extends Workflow {
171167
btnSelectHostFolder.disabled = true;
172168
let serialConnect = async (event) => {
173169
try {
174-
await this.showBusy(this.connectToSerial());
170+
await this.connectToSerial();
175171
} catch (e) {
176172
//console.log(e);
177173
//alert(e.message);
@@ -291,7 +287,7 @@ class USBWorkflow extends Workflow {
291287

292288
// At this point we should see if we should init the file client and check if have a saved dir handle
293289
let fileops = new FileOps(this.repl, false);
294-
if (await fileops.isReadOnly()) {
290+
if (await this.showBusy(fileops.isReadOnly())) {
295291
// UID Only needed for matching the CIRCUITPY drive with the Serial Terminal
296292
await this.showBusy(this._getDeviceUid());
297293
let modal = this.connectDialog.getModal();

sass/base/_base.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
@use "../base/variables" as *;
2+
@use "sass:color";
3+
14
html {
25
box-sizing: border-box;
36
}
@@ -64,7 +67,7 @@ h5 {
6467
}
6568

6669
&:hover {
67-
background-color: darken($purple, 15%);
70+
background-color: color.adjust($purple, $lightness: -15%);
6871
}
6972

7073
&.hidden {
@@ -77,7 +80,7 @@ h5 {
7780
background-color: $gray;
7881

7982
&:hover {
80-
background-color: darken($gray, 15%);
83+
background-color: color.adjust($gray, $lightness: -15%);
8184
}
8285
}
8386

sass/layout/_grid.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use "../base/variables" as *;
2+
13
.container {
24
width: 100%;
35
margin: 0 auto;

sass/layout/_header.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
@use "../base/variables" as *;
2+
@use "../base/mixins" as *;
3+
14
#site-header {
25
display: grid;
36
grid-template-rows: 1fr 3px;

sass/layout/_header_mobile.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use "../base/variables" as *;
2+
13
#mobile-header {
24
display: none;
35
background-color: #333;

sass/layout/_layout.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
@use "../base/variables" as *;
2+
@use "sass:color";
3+
14
.layout {
25
height: 100vh;
36
height: calc(var(--vh, 1vh) * 100);
@@ -170,7 +173,7 @@
170173
background-color: $gray;
171174

172175
&:hover {
173-
background-color: darken($gray, 15%);
176+
background-color: color.adjust($gray, $lightness: -15%);
174177
}
175178

176179
&.active {

sass/style.scss

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
@charset "utf-8";
22

3-
@import '/node_modules/@fortawesome/fontawesome-free/css/all.min.css';
4-
@import '/node_modules/@xterm/xterm/css/xterm.css';
3+
@use '/node_modules/@fortawesome/fontawesome-free/css/all.min.css';
4+
@use '/node_modules/@xterm/xterm/css/xterm.css';
55

6-
@import './vendors/normalize';
6+
@use 'vendors/normalize';
77

8-
@import './base/variables';
9-
@import './base/typography';
10-
@import './base/mixins';
11-
@import './base/base';
8+
@use 'base/variables';
9+
@use 'base/typography';
10+
@use 'base/mixins';
11+
@use 'base/base';
1212

13-
@import './layout/layout';
14-
@import './layout/grid';
15-
@import './layout/editor';
16-
@import './layout/header';
17-
@import './layout/header_mobile';
13+
@use 'layout/layout';
14+
@use 'layout/grid';
15+
@use 'layout/editor';
16+
@use 'layout/header';
17+
@use 'layout/header_mobile';

0 commit comments

Comments
 (0)