Skip to content

Commit 14a544a

Browse files
committed
run: fix --kvm
1 parent 4aa429f commit 14a544a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

run

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def main(args, extra_args=None):
5050
if args.kernel_cli is not None:
5151
kernel_cli += ' {}'.format(args.kernel_cli)
5252
kernel_cli_after_dash = ''
53-
extra_emulator_args = args.extra_emulator_args.copy()
53+
extra_emulator_args = []
5454
extra_qemu_args = []
5555
if args.debug_vm:
5656
debug_vm = ['gdb', '-q', '-ex', 'start', '--args']
@@ -157,6 +157,7 @@ def main(args, extra_args=None):
157157
'--machine-type', 'VExpress_GEM5_V1',
158158
]
159159
else:
160+
extra_emulator_args.extend(extra_qemu_args)
160161
os.makedirs(common.run_dir, exist_ok=True)
161162
if args.debug_vm:
162163
serial_monitor = []
@@ -165,13 +166,12 @@ def main(args, extra_args=None):
165166
if args.kvm:
166167
extra_emulator_args.append('-enable-kvm')
167168
if args.kgdb:
168-
extra_qemu_args.extend(['-serial', 'tcp::{},server,nowait'.format(common.gdb_port)])
169+
extra_emulator_args.extend(['-serial', 'tcp::{},server,nowait'.format(common.gdb_port)])
169170
if args.prebuilt:
170171
common.mkdir()
171172
qemu_executable = "qemu-system-{}".format(args.arch)
172173
else:
173174
qemu_executable = common.qemu_executable
174-
extra_emulator_args = extra_qemu_args + args.extra_emulator_args
175175
cmd = (
176176
debug_vm +
177177
[
@@ -275,7 +275,8 @@ def main(args, extra_args=None):
275275
"sleep 2;./rungdb -a '{}' -L '{}' -n '{}' {}" \
276276
.format(args.arch, args.linux_build_id, args.run_id, args.tmux_args)
277277
])
278-
cmd += extra_emulator_args
278+
cmd.extend(extra_emulator_args)
279+
cmd.extend(args.extra_emulator_args)
279280
if debug_vm or args.terminal:
280281
out_file = None
281282
else:

0 commit comments

Comments
 (0)