Skip to content

Commit 54e15e0

Browse files
committed
multicore: remove references to PCSI
1 parent ba2976c commit 54e15e0

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

README.adoc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10603,10 +10603,7 @@ since gem5 is able to detect when nothing will ever happen, and exits.
1060310603

1060410604
When GDB step debugging, switch between cores with the usual `thread` commands, see also: <<gdb-step-debug-multicore-userland>>.
1060510605

10606-
Bibliography:
10607-
10608-
* https://stackoverflow.com/questions/20055754/arm-start-wakeup-bringup-the-other-cpu-cores-aps-and-pass-execution-start-addre
10609-
* https://stackoverflow.com/questions/980999/what-does-multicore-assembly-language-look-like/33651438#33651438
10606+
Bibliography: https://stackoverflow.com/questions/980999/what-does-multicore-assembly-language-look-like/33651438#33651438
1061010607

1061110608
===== WFE and SEV
1061210609

@@ -10690,6 +10687,8 @@ The Linux kernel wakes up the secondary cores in this exact same way at: https:/
1069010687

1069110688
In gem5, CPU 1 starts woken up from the start, so PSCI is not needed. TODO gem5 actually blows up if we try to do the `hvc` call, understand why.
1069210689

10690+
Bibliography: https://stackoverflow.com/questions/20055754/arm-start-wakeup-bringup-the-other-cpu-cores-aps-and-pass-execution-start-addre/53473447#53473447
10691+
1069310692
===== DMB
1069410693

1069510694
TODO: create and study a minimal examples in gem5 where the `DMB` instruction leads to less cycles: https://stackoverflow.com/questions/15491751/real-life-use-cases-of-barriers-dsb-dmb-isb-in-arm

baremetal/arch/aarch64/multicore.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ cpu0_only:
3939
/* Wake up CPU 1 from initial sleep!
4040
* See:https://github.com/cirosantilli/linux-kernel-module-cheat#psci
4141
*/
42-
/* Function identifier: PCSI CPU_ON. */
42+
/* PCSI function identifier: CPU_ON. */
4343
ldr w0, =0xc4000003
4444
/* Argument 1: target_cpu */
4545
mov x1, 1

baremetal/arch/arm/multicore.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ cpu1_sleep_forever:
2020
b cpu1_sleep_forever
2121
cpu0_only:
2222
#if !defined(GEM5)
23-
/* PCSI CPU_ON. */
23+
/* PSCI CPU_ON. */
2424
ldr r0, =0x84000003
2525
mov r1, #1
2626
ldr r2, =cpu1_only

0 commit comments

Comments
 (0)