Treat trailing-delimiter as true by default

Author: cirras

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Incorrect (de)serialization of some data structures containing arrays with trailing delimiters.
 - Incorrect (de)serialization of data structures containing both `<dummy>` and `<field>` elements.'
   (Only `ChestCloseServerPacket` was impacted.)
 - Sanitize strings within chunked sections of protocol data structures.

protocol_code_generator/generate/field_code_generator.py

@@ -100,9 +100,6 @@ def _validate_array_field(self):
             if self._delimited:
                 raise RuntimeError("Only arrays can be delimited.")
 
-        if not self._delimited and self._trailing_delimiter:
-            raise RuntimeError("Only delimited arrays can have a trailing delimiter.")
-
     def _validate_length_field(self):
         if self._length_field:
             if self._name is None:

protocol_code_generator/generate/object_code_generator.py

@@ -250,7 +250,7 @@ def _generate_array(self, protocol_array):
             .comment(get_comment(protocol_array))
             .array_field(True)
             .delimited(delimited)
-            .trailing_delimiter(get_boolean_attribute(protocol_array, "trailing-delimiter"))
+            .trailing_delimiter(get_boolean_attribute(protocol_array, "trailing-delimiter", True))
             .build()
         )