Fix sonar issues in protocol code generator

Author: cirras

protocol_code_generator/generate/code_block.py

@@ -104,8 +104,7 @@ def __bool__(self):
     def to_string(self, package_path):
         result = ""
 
-        relativize = lambda i: i.relativize(package_path)
-        import_strings = set(map(relativize, self._imports))
+        import_strings = {i.relativize(package_path) for i in self._imports}
         import_strings = sorted(import_strings, reverse=True)
 
         for import_ in import_strings:

protocol_code_generator/generate/field_code_generator.py

@@ -548,17 +548,15 @@ def _check_field_accessible(self, field):
 
     def _get_serialize_length_expression(self):
         expression = self._length_string
-        if expression is not None:
-            if not expression.isdigit():
-                self._check_field_accessible(expression)
-                expression = f'data._{expression}'
+        if expression is not None and not expression.isdigit():
+            self._check_field_accessible(expression)
+            expression = f'data._{expression}'
         return expression
 
     def _get_deserialize_length_expression(self):
         expression = self._length_string
-        if expression is not None:
-            if not expression.isdigit():
-                self._check_field_accessible(expression)
+        if expression is not None and not expression.isdigit():
+            self._check_field_accessible(expression)
         return expression
 
     @staticmethod

protocol_code_generator/generate/object_code_generator.py

@@ -129,7 +129,7 @@ def code(self):
         return result
 
     def _generate_init_method(self):
-        result = CodeBlock().add(f'def __init__(self')
+        result = CodeBlock().add('def __init__(self')
         if self._data.init_params:
             result.add(', *')
         for param in self._data.init_params:
@@ -238,12 +238,13 @@ def _generate_deserialize_method(self):
 
     def _generate_repr_method(self):
         field_to_repr_str = lambda field: field + "={repr(self._" + field + ")}"
-        repr_str = ', '.join(map(field_to_repr_str, self._data.repr_fields))
+        repr_field_strs = [field_to_repr_str(field) for field in self._data.repr_fields]
+        repr_expression = 'f"' + self._class_name + '(' + ', '.join(repr_field_strs) + ')"'
         return (
             CodeBlock()
             .add_line('def __repr__(self):')
             .indent()
-            .add_line(f'return f"{self._class_name}({repr_str})"')
+            .add_line(f'return {repr_expression}')
             .unindent()
         )
 

protocol_code_generator/util/docstring_utils.py

@@ -3,7 +3,7 @@
 from protocol_code_generator.generate.code_block import CodeBlock
 
 
-def generate_docstring(protocol_comment, notes=[]):
+def generate_docstring(protocol_comment):
     lines = []
 
     if protocol_comment: