controller(listVMs): reduce allocations (#400)

edigaryev · web-flow · commit bdc2af3d580d · 2026-02-05T22:02:21.000+01:00
* controller(listVMs): reduce allocations

* Declare an empty, non-nil slice to return [] when no objects are found
diff --git a/internal/controller/api_vms.go b/internal/controller/api_vms.go
@@ -344,7 +344,9 @@ func (controller *Controller) listVMs(ctx *gin.Context) responder.Responder {
 		return responder.Code(http.StatusInternalServerError)
 	}
 
-	vms := make([]v1.VM, 0, len(allVMs))
+	// Declare an empty, non-nil slice to
+	// return [] when no objects are found
+	vms := []v1.VM{}
 
 Outer:
 	for _, vm := range allVMs {

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,9 @@ func (controller Controller) listVMs(ctx gin.Context) responder.Responder {`
`344`	`344`	`return responder.Code(http.StatusInternalServerError)`
`345`	`345`	`}`
`346`	`346`
`347`		`- vms := make([]v1.VM, 0, len(allVMs))`
	`347`	`+ // Declare an empty, non-nil slice to`
	`348`	`+ // return [] when no objects are found`
	`349`	`+ vms := []v1.VM{}`
`348`	`350`
`349`	`351`	`Outer:`
`350`	`352`	`for _, vm := range allVMs {`