tart exec timeout ?

[RStzl]

Hi, new to Tart and delighted by it...

A question about the recently-introduced "tart exec" shortcut: release 2.27.1 limited its usefulness by adding a 1-second timeout. Why was that done, and would implementing a timeout parameter (with 0 = no timeout) be considered reasonable?

Btw, the usage says tart exec <name> [-i] [-t] <command> ..., but it is actually tart exec [-i] [-t] <name> <command> ....

[edigaryev]

A question about the recently-introduced "tart exec" shortcut: release 2.27.1 limited its usefulness by adding a 1-second timeout. Why was that done, and would implementing a timeout parameter (with 0 = no timeout) be considered reasonable?

Establishing communication with the agent usually is much faster than a second, so we fail fast to highlight a likely non-functioning agent.

Are you trying to tart exec into a Linux VM by a chance?

Btw, the usage says tart exec <name> [-i] [-t] <command> ..., but it is actually tart exec [-i] [-t] <name> <command> ....

Good catch, will fix this in #1090.

[RStzl]

No, I just expected it to be able to execute commands on a Mac VM that take longer than a second, which die with Error: RPC timed out before completing. It's no big deal (ssh ftw), but I was curious about the artificial limitation.

[edigaryev]

Hey, thanks for noting this! 👍

I've mistakenly thought that this timeout only applies to connection establishment process, not to the whole RPC call duration.

Removed it for now in 8dc8b64 until we find a better way to achieve fail-fast behavior.

Also, I've identified some reliability issues in Tart Guest Agent in cirruslabs/tart-guest-agent#13 and quirks in cirruslabs/macos-image-templates#243, hopefully they will be all released soon too 🚀

[RStzl]

Excellent - thanks for responding!