Skip to content

Commit 9984792

Browse files
jsf9kjmorrowomni
authored andcommitted
Install/upgrade setuptools and wheel when upgrading pip
When wheel gets installed alongside other packages, it may not get used when those other packages are installed. When that happens I see warnings like this: DEPRECATION: ansible-core is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559 This change should get rid of these warnings. Nota bene: This is the practice we follow in the Dockerfile in cisagov/skeleton-docker, but for some reason we never started using it in our workflows.
1 parent 847cd13 commit 9984792

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
run: go install ${PACKAGE_URL}@${PACKAGE_VERSION}
9090
- name: Install dependencies
9191
run: |
92-
python -m pip install --upgrade pip
92+
python -m pip install --upgrade pip setuptools wheel
9393
pip install --upgrade --requirement requirements-test.txt
9494
- name: Set up pre-commit hook environments
9595
run: pre-commit install-hooks

0 commit comments

Comments
 (0)