Merge pull request #54 from cisagov/improvement/bash_fork_packer_commands

Run hooks in parallel on each path

Author: mcdonnnj

hooks/packer_fmt.sh

@@ -17,14 +17,21 @@ source "$SCRIPT_DIR/../lib/util.sh"
 
 util::parse_cmdline "$@"
 
-error=0
-
+pids=()
 for file in "${FILES[@]}"; do
-  if ! packer fmt "${ARGS[@]}" -- "$file"; then
+  # Check each path in parallel
+  {
+    packer fmt "${ARGS[@]}" -- "$file"
+  } &
+  pids+=("$!")
+done
+
+error=0
+exit_code=0
+for pid in "${pids[@]}"; do
+  wait "$pid" || exit_code=$?
+  if [[ $exit_code -ne 0 ]]; then
     error=1
-    echo
-    echo "Failed path: $file"
-    echo "================================"
   fi
 done
 

hooks/packer_validate.sh

@@ -4,6 +4,25 @@ set -o nounset
 set -o errexit
 set -o pipefail
 
+function packer_validate() {
+  local exit_code=0
+
+  packer init . > /dev/null
+
+  # Allow us to get output if the validation fails
+  set +o errexit
+  validate_output=$(packer validate "${ARGS[@]}" . 2>&1)
+  exit_code=$?
+  set -o errexit
+
+  if [[ $exit_code -ne 0 ]]; then
+    echo "Validation failed in $path"
+    echo -e "$validate_output\n\n"
+  fi
+
+  return $exit_code
+}
+
 if [ -z "$(command -v packer)" ]; then
   echo "packer is required"
   exit 1
@@ -19,17 +38,22 @@ util::parse_cmdline "$@"
 
 util::get_unique_directory_paths "${FILES[@]}"
 
-error=0
-
+pids=()
 for path in "${UNIQUE_PATHS[@]}"; do
-  pushd "$path" > /dev/null
+  # Check each path in parallel
+  {
+    pushd "$path" > /dev/null
+    packer_validate
+  } &
+  pids+=("$!")
+done
 
-  packer init . > /dev/null
-  if ! packer validate "${ARGS[@]}" .; then
+error=0
+exit_code=0
+for pid in "${pids[@]}"; do
+  wait "$pid" || exit_code=$?
+  if [[ $exit_code -ne 0 ]]; then
     error=1
-    echo
-    echo "Failed path: $path"
-    echo "================================"
   fi
 done