Watermarks are wonky

[jsf9k]

🐛 Summary

According to the way that the background LaTeX package is being called in #53, these statements concerning the DHS logo watermark should be true:

1. The only page of the report that should have the watermark is the table of contents page.
2. The watermark on the table of contents page should be quite faint, like it was in our reports up until September of this year (before ⚠️ CONFLICT! Lineage pull request for: skeleton #51 and Fix matplotlib bug and assorted warnings #53).

This is what is actually true:

1. The title page does not have a watermark, which is what we expect and desire.
2. The table of contents does have a watermark but, although it is rather transparent, it is not nearly as transparent as it was before Fix matplotlib bug and assorted warnings #53.
3. All pages following the table of contents have a much more transparent watermark than the table of contents page, even though they should have no watermark at all.

Note that I was only able to get rid of an aggressively non-opaque watermark on the title page by moving the location of the background configuration in #53.

The only thing I can think of is that after the update to Bullseye in #51 we have a newer version of the background package, and all the LaTeX-fu in that report to make it look like a fancy Word document is now somehow colliding with it.

To reproduce

Use the code in this repo to create a Trustworthy Email report.

Expected behavior

Described above.

[KeithBonesJr]

@dav3r and @jsf9k is this something you'd like for us to take a stab at locally or is it something that's far outside our wheel house? It's ok, you all can be honest with us. 👍

[dav3r]

@KeithBonesJr Has anyone on your team verified if @jsf9k's original comments from 2 years ago are still true now? It's possible that newer LaTeX packages have changed things since then.

Also, is this important enough for anyone to spend any time on?

[KeithBonesJr]

@dav3r looking into this now. In terms of importance, unfortunately our contractor management heard we can generate sample reports and wanted us to look into this since it's one of VS's lingering issue. If we can resolve it on our own, my plan is to let them know it'll continue to be an issue. Also thanks! @jsf9k

[KeithBonesJr]

Just had a glance and noticed the issue was fixed for the trustymail report, not the HTTPS report. My guess is a similar version bump may need to happen within the https://github.com/cisagov/pshtt repository? @dav3r @jsf9k

[jsf9k]

Just had a glance and noticed the issue was fixed for the trustymail report, not the HTTPS report. My guess is a similar version bump may need to happen within the https://github.com/cisagov/pshtt repository? @dav3r @jsf9k

What exactly do you mean by "a similar version bump"?

[KeithBonesJr]

Just had a glance and noticed the issue was fixed for the trustymail report, not the HTTPS report. My guess is a similar version bump may need to happen within the https://github.com/cisagov/pshtt repository? @dav3r @jsf9k

What exactly do you mean by "a similar version bump"?

I was thinking you did a version bump on bull-eye but it looks like you moved the version of the background configuration. Oversight on my end.