Skip to content

Commit 6d90a8e

Browse files
authored
follow up fixes for recommended labels (#143)
1 parent a9193d3 commit 6d90a8e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

scripts/generators/k8s/templates/services/deployment.yaml.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ spec:
4242
valueFrom:
4343
fieldRef:
4444
apiVersion: v1
45-
fieldPath: metadata.labels['service']
45+
fieldPath: metadata.labels['app.kubernetes.io/name']
4646
ports:
4747
- containerPort: {{ service_port|default('8080') }}
4848
resources:

scripts/generators/k8s/templates/services/service.yaml.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ metadata:
3131
{% endif %}
3232
spec:
3333
selector:
34-
app: {{ appName|default('AppSimulatorApp') }}
35-
service: {{ serviceName }}
34+
app.kubernetes.io/part-of: {{ appName|default('AppSimulatorApp') }}
35+
app.kubernetes.io/name: {{ serviceName }}
3636
ports:
3737
- protocol: TCP
3838
targetPort: {{ servicePort|default('8080') }}

0 commit comments

Comments
 (0)