reviewed golangci.yml and fixed some issues

Author: stonedu1011

build/ci/golangci.yml

@@ -69,16 +69,28 @@ linters:
       comparison: false
     exhaustive:
       default-signifies-exhaustive: true
-    gosec:
-      severity: medium
+    recvcheck:
+      disable-builtin: false
+      exclusions:
+       - "*.UnmarshalText"
+       - "*.UnmarshalJSON"
+       - "*.UnmarshalYAML"
+       - "*.UnmarshalXML"
+       - "*.UnmarshalBinary"
+       - "*.GobDecode"
+       - "*.String"
+       - "*.Scan"
     staticcheck:
       checks:
         - "all"
-        - "-QF*"
-        - "-S1039" # unnecessary use of fmt.Sprintf
-        # assigning the result of this type assertion to a variable could eliminate type assertions in switch cases
+        # Following are too verbose. Re-enable if we could control output based on severities
+        - "-QF*" # Quickfixes
+        - "-ST1*" # Stylistic issues.
         # TODO Tech debt to fix
-        - "-S*"
+        - "-S*" # Any other code simplication issues. Too many places (~100)
+        - "-S1034" # "could eliminate this type assertion". Too many places (~100)
+        - "-SA1019" # "Using a deprecated function, variable, constant or field". Re-enable when OPA is migrated
+        - "-SA1006" # "printf-style function without additional arguments". We probably won't fix these
   exclusions:
     generated: lax
     presets:
@@ -102,12 +114,12 @@ severity:
     - linters:
         - contextcheck
         - noctx
-        - staticcheck
         - recvcheck
       severity: warning
     - linters:
         - errorlint
         - exhaustive
+        - staticcheck
         - unused
       severity: info
 

cmd/lanai-cli/cmdutils/flag_base64.go

@@ -49,7 +49,7 @@ func (v *Base64Value) Set(s string) error {
 	return nil
 }
 
-func (v Base64Value) Type() string {
+func (v *Base64Value) Type() string {
 	return "base64"
 }
 
@@ -78,7 +78,7 @@ func (v Base64Value) Type() string {
 //	panic("implement me")
 //}
 
-func (v Base64Value) decode(s string) ([]byte, error) {
+func (v *Base64Value) decode(s string) ([]byte, error) {
 	var data []byte
 	_, e := base64.StdEncoding.Decode([]byte(s), data)
 	return data, e

cmd/lanai-cli/cmdutils/go_cmd.go

@@ -272,7 +272,7 @@ func GoModTidy(ctx context.Context, extraShellOptions []ShCmdOptions, opts ...Go
 }
 
 func GetGoMod(ctx context.Context, opts ...GoCmdOptions) (*GoMod, error) {
-	cmd := fmt.Sprintf("go mod edit -json")
+	cmd := "go mod edit -json"
 	for _, f := range opts {
 		f(&cmd)
 	}

cmd/lanai-cli/cmdutils/matcher_strings.go

@@ -64,7 +64,7 @@ func WithSubString(substr string, caseInsensitive bool) StringMatcher {
 }
 
 func AnyNonEmptyString() StringMatcher {
-    desc := fmt.Sprintf("matches any non-empty string")
+    desc := "matches any non-empty string"
     return &GenericMatcher[string]{
         MatchFunc: func(_ context.Context, value string) (bool, error) {
             return value != "", nil

cmd/lanai-cli/cmdutils/shell.go

@@ -132,20 +132,20 @@ func RunShellCommands(ctx context.Context, opts ...ShCmdOptions) (uint8, error)
 }
 
 func runSingleCommand(ctx context.Context, cmd string, opt *ShCmdOption) (uint8, error){
-	p, err := syntax.NewParser().Parse(strings.NewReader(cmd), "")
-	if err != nil {
-		return 1, err
+	p, e := syntax.NewParser().Parse(strings.NewReader(cmd), "")
+	if e != nil {
+		return 1, e
 	}
 
-	r, err := interp.New(
+	r, e := interp.New(
 		interp.Params("-e"),
 		interp.Dir(opt.Dir),
 		interp.Env(expand.ListEnviron(opt.Env...)),
 		interp.OpenHandler(openHandler),
 		interp.StdIO(opt.Stdin, opt.Stdout, opt.Stderr),
 	)
-	if err != nil {
-		return 1, err
+	if e != nil {
+		return 1, e
 	}
 
 	if opt.ShowCmd && !ShCmdLogDisabled {
@@ -169,7 +169,7 @@ func runSingleCommand(ctx context.Context, cmd string, opt *ShCmdOption) (uint8,
 	}
 
 	if e := r.Run(ctx, p); e != nil {
-		if status, ok := interp.IsExitStatus(err); ok {
+		if status, ok := interp.IsExitStatus(e); ok {
 			return status, e
 		}
 		return 1, e

cmd/lanai-cli/deps/dropreplace.go

@@ -70,7 +70,7 @@ func RunDropReplace(cmd *cobra.Command, _ []string) error {
 	if e != nil {
 		return fmt.Errorf("failed to drop invalid replace: %v", e)
 	}
-	changed = len(dropped) != 0
+	changed = changed || len(dropped) != 0
 
 	if changed {
 		if e := cmdutils.GoModTidy(cmd.Context(), nil); e != nil {
@@ -79,7 +79,7 @@ func RunDropReplace(cmd *cobra.Command, _ []string) error {
 	}
 
 	// mark changes if requested
-	msg := fmt.Sprintf("dropped replaces in go.mod for CI/CD process")
+	msg := "dropped replaces in go.mod for CI/CD process"
 	tag, e := markChangesIfRequired(cmd.Context(), msg, cmdutils.GitFilePattern("go.mod", "go.sum"))
 	if e == nil && tag != "" {
 		logger.WithContext(cmd.Context()).Infof(`Modified go.mod/go.sum are tagged with Git Tag [%s]`, tag)

cmd/lanai-cli/deps/updatedep.go

@@ -71,7 +71,7 @@ func RunUpdateDep(cmd *cobra.Command, _ []string) error {
 	}
 
 	// mark changes if requested
-	msg := fmt.Sprintf("updated versions of private modules")
+	msg := "updated versions of private modules"
 	tag, e := markChangesIfRequired(cmd.Context(), msg, cmdutils.GitFilePattern("go.mod", "go.sum"))
 	if e == nil && tag != "" {
 		logger.WithContext(cmd.Context()).Infof(`Modified go.mod/go.sum are tagged with Git Tag [%s]`, tag)

pkg/appconfig/provider.go

@@ -66,15 +66,15 @@ type ProviderMeta struct {
 	Precedence int                    //the precedence for which the settings will take effect.
 }
 
-func (m ProviderMeta) GetSettings() map[string]interface{} {
+func (m *ProviderMeta) GetSettings() map[string]interface{} {
 	return m.Settings
 }
 
-func (m ProviderMeta) Order() int {
+func (m *ProviderMeta) Order() int {
 	return m.Precedence
 }
 
-func (m ProviderMeta) IsLoaded() bool {
+func (m *ProviderMeta) IsLoaded() bool {
 	return m.Loaded
 }
 

pkg/appconfig/provider_group.go

@@ -35,11 +35,11 @@ func NewStaticProviderGroup(order int, providers ...Provider) *StaticProviderGro
 	}
 }
 
-func (g StaticProviderGroup) Order() int {
+func (g *StaticProviderGroup) Order() int {
 	return g.Precedence
 }
 
-func (g StaticProviderGroup) Providers(_ context.Context, _ bootstrap.ApplicationConfig) []Provider {
+func (g *StaticProviderGroup) Providers(_ context.Context, _ bootstrap.ApplicationConfig) []Provider {
 	return g.StaticProviders
 }
 

pkg/data/types/pqcrypt/context.go

@@ -123,7 +123,7 @@ type EncryptedRaw struct {
 }
 
 // GormDataType implements schema.GormDataTypeInterface
-func (EncryptedRaw) GormDataType() string {
+func (*EncryptedRaw) GormDataType() string {
 	return "jsonb"
 }