strict pdb typemeta check

Author: waynz0r

patch/ignorepdb.go

@@ -34,17 +34,15 @@ func IgnorePDBSelector() CalculateOption {
 			return []byte{}, []byte{}, errors.Wrap(err, "could not unmarshal byte sequence for modified")
 		}
 
-		if isPDB(currentResource) || isPDB(modifiedResource) {
-			if reflect.DeepEqual(getPDBSelector(currentResource), getPDBSelector(modifiedResource)) {
-				var err error
-				current, err = deletePDBSelector(currentResource)
-				if err != nil {
-					return nil, nil, errors.Wrap(err, "delete pdb selector from current")
-				}
-				modified, err = deletePDBSelector(modifiedResource)
-				if err != nil {
-					return nil, nil, errors.Wrap(err, "delete pdb selector from modified")
-				}
+		if isPDB(currentResource) && isPDB(modifiedResource) && reflect.DeepEqual(getPDBSelector(currentResource), getPDBSelector(modifiedResource)) {
+			var err error
+			current, err = deletePDBSelector(currentResource)
+			if err != nil {
+				return nil, nil, errors.Wrap(err, "delete pdb selector from current")
+			}
+			modified, err = deletePDBSelector(modifiedResource)
+			if err != nil {
+				return nil, nil, errors.Wrap(err, "delete pdb selector from modified")
 			}
 		}
 

tests/integration_test.go

@@ -576,6 +576,10 @@ func TestIntegration(t *testing.T) {
 			}),
 		NewTestMatch("pdb match",
 			&v1beta12.PodDisruptionBudget{
+				TypeMeta: metav1.TypeMeta{
+					APIVersion: v1beta12.SchemeGroupVersion.String(),
+					Kind:       "PodDisruptionBudget",
+				},
 				ObjectMeta: standardObjectMeta(),
 				Spec: v1beta12.PodDisruptionBudgetSpec{
 					MinAvailable: intstrRef(intstr.FromInt(1)),
@@ -588,6 +592,10 @@ func TestIntegration(t *testing.T) {
 			}),
 		NewTestDiff("pdb diff on matchlabels",
 			&v1beta12.PodDisruptionBudget{
+				TypeMeta: metav1.TypeMeta{
+					APIVersion: v1beta12.SchemeGroupVersion.String(),
+					Kind:       "PodDisruptionBudget",
+				},
 				ObjectMeta: standardObjectMeta(),
 				Spec: v1beta12.PodDisruptionBudgetSpec{
 					MinAvailable: intstrRef(intstr.FromInt(1)),