Skip to content

Add option to ignore GARP requests #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to ignore GARP requests #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0de92f
Toggle for GARP requests in pretest
EADRBYS Jun 25, 2024
c59bff5
Remove GARP printout
ehhkjjn May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main_dpdk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ enum {
OPT_DISABLE_IEEE_1588,
OPT_LATENCY_DIAG,
OPT_DEFER_START_QUEUES,
OPT_GARP_IGNORE,

/* no more pass this */
OPT_MAX
Expand Down Expand Up @@ -328,6 +329,7 @@ static CSimpleOpt::SOption parser_options[] =
{ OPT_DISABLE_IEEE_1588, "--disable-ieee-1588", SO_NONE},
{ OPT_LATENCY_DIAG, "--latency-diag", SO_NONE},
{ OPT_DEFER_START_QUEUES, "--defer-start-queues", SO_NONE},
{ OPT_GARP_IGNORE, "--ignore-garp", SO_NONE},

SO_END_OF_OPTIONS
};
Expand Down Expand Up @@ -365,6 +367,7 @@ static int COLD_FUNC usage() {
printf(" so we do not call them by default for now. Leaving this as option in case someone thinks it is helpful for him \n");
printf(" This it temporary option. Will be removed in the future \n");
printf(" -d : Duration of the test in sec (default is 3600). Look also at --nc \n");
printf(" --ignore-garp : Ignore received gratuitous ARPs for setting port addresses during setup. Default is false.\n");
printf(" -e : Like -p but src/dst IP will be chosen according to the port (i.e. on client port send all packets with client src and server dest, and vice versa on server port \n");
printf(" --flip : Each flow will be sent both from client to server and server to client. This can achieve better port utilization when flow traffic is asymmetric \n");
printf(" --hdrh : Report latency using high dynamic range histograms (http://hdrhistogram.org)\n");
Expand Down Expand Up @@ -980,6 +983,9 @@ COLD_FUNC static int parse_options(int argc, char *argv[], bool first_time ) {
case OPT_DEFER_START_QUEUES:
po->preview.set_defer_start_queues(true);
break;
case OPT_GARP_IGNORE:
po->m_garp_ignore = true;
break;

default:
printf("Error: option %s is not handled.\n\n", args.OptionText());
Expand Down
5 changes: 3 additions & 2 deletions src/pre_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,10 @@ int CPretest::handle_rx(int port_id, int queue_id) {
}
}
} else {
// ARP request not to our IP. Check if this is gratitues ARP for something we need.
// ARP request not to our IP. Check if this is gratuitous ARP for something we need.
if ((arp->m_arp_tip == arp->m_arp_sip)
&& (rcv_addr = port->find_next_hop(ntohl(arp->m_arp_tip), vlan_id))) {
&& (rcv_addr = port->find_next_hop(ntohl(arp->m_arp_tip), vlan_id))
&& !CGlobalInfo::m_options.m_garp_ignore) {
rcv_addr->set_mac((uint8_t *)&arp->m_arp_sha);
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/trex_global.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ class CParserOption {
m_tunnel_loopback = false;
m_tunnel_enabled = false;
m_rx_dp_ring_size = 0;
m_garp_ignore = false;
}

CParserOption(){
Expand Down Expand Up @@ -717,6 +718,7 @@ class CParserOption {
bool m_astf_best_effort_mode;
bool m_tunnel_loopback;
uint16_t m_rx_dp_ring_size; // Size of rings between Dp and Rx.
bool m_garp_ignore;


public:
Expand Down