Skip to content

Lower the min value of tcp.delay_ack_msec #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lower the min value of tcp.delay_ack_msec #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/trex_astf.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3915,7 +3915,7 @@ link:cp_astf_docs/index.html[python index]
| tcp.keepidle |2-65533|5|-|+| value in second for TCP keepidle
| tcp.keepintvl |2-65533|7|-|+| value in second for TCP keepalive interval
| tcp.blackhole |0,1,2|0|-|+| 0 - return RST packet in case of error. 1- return of RST only in SYN. 2- don't return any RST packet, make a blackhole.
| tcp.delay_ack_msec | 20-50000|100|-|+| delay ack timeout in msec. Reducing this value will reduce the performance but will reduce the active flows
| tcp.delay_ack_msec | 1-50000|100|-|+| delay ack timeout in msec. Reducing this value will reduce the performance but will reduce the active flows
| tcp.no_delay | 0-3 | 0|+|+| 2 bits: LSB - Nagle Algorithm (0 - Enabled, 1 - Disabled). MSB - Force Push (FP) (0 - Disabled, 1 - Enabled).
| tcp.no_delay_counter | 0-65533 | 0|+|+| number of recv bytes to wait until ack is sent. notice ack can be triggered by tcp timer, in order to ensure fixed number of sent packets until ack you should increase the *tcp.initwnd* tunable. otherwise no_delay_counter will race with the tcp timer.
| scheduler.rampup_sec | 3-60000 | disabled |-|+| scheduler rampup in seconds. After this time the throughput would be the maximum. the throughput increases linearly every 1 sec.
Expand Down
2 changes: 1 addition & 1 deletion src/astf/astf_db.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,7 @@ bool CAstfDB::read_tunables(CTcpTuneables *tune, Json::Value tune_json) {
}

if (read_tunable_uint16(tune,json,"delay_ack_msec",CTcpTuneables::tcp_delay_ack,tune->m_tcp_delay_ack_msec)){
tunable_min_max_u32("delay_ack_msec",tune->m_tcp_delay_ack_msec,20,50000);
tunable_min_max_u32("delay_ack_msec",tune->m_tcp_delay_ack_msec,1,50000);
}

if (read_tunable_uint16(tune, json, "no_delay_counter", CTcpTuneables::tcp_no_delay_counter,tune->m_tcp_no_delay_counter)){
Expand Down
2 changes: 1 addition & 1 deletion src/astf/astf_db.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class CTcpTuneables {
uint16_t m_tcp_keepinit;
uint16_t m_tcp_keepidle;
uint16_t m_tcp_keepintvl;
uint16_t m_tcp_delay_ack_msec; /* 20-500msec */
uint16_t m_tcp_delay_ack_msec; /* 1-500msec */

uint16_t m_tcp_mss;
uint16_t m_tcp_initwnd; /* init window*/
Expand Down