Skip to content

Fix ASTF python api l7_percent bug #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ASTF python api l7_percent bug #1181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d3363
fix ASTF python api l7_percent bug
afaure-anssi Jun 27, 2025
3881653
improve l7_percent bug fix
afaure-anssi Jun 27, 2025
9028249
more elegant solution for the 0,5 cps limit
afaure-anssi Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions scripts/automation/trex_control_plane/interactive/trex/astf/trex_astf_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,15 +2100,44 @@ def __init__(self, default_ip_gen, default_c_glob_info=None, default_s_glob_info
d_ports[d_port] = cap_file

all_cap_info.append({"ip_gen": ip_gen, "prog_c": prog_c, "prog_s": prog_s, "glob_c": glob_c, "glob_s": glob_s,
"cps": cps, "d_port": d_port, "my_assoc": my_assoc,"limit":cap.limit, "cont":cap.cont, "tg_name": cap.tg_name})
"cps": cps, "l7_percent": l7_percent, "d_port": d_port, "my_assoc": my_assoc,"limit":cap.limit, "cont":cap.cont, "tg_name": cap.tg_name})
# calculate cps from l7 percent
# first know how much percent it represents from the trafic
# 100 | ?
# total_payload | payload_len
#
# trafic percent = payload * 100 / total_payload
#
# then go from actual trafic percent to expected trafic percent
#
# 1 cps | trafic percent
# ? cps | expected_percent
#
# final_cps = expected_percent / trafic_percent
if mode == "l7_percent":
lowest = 1
percent_sum = 0
for c in all_cap_info:
c["cps"] = c["prog_c"].payload_len * 100.0 / total_payload
percent_sum += c["cps"]
payload_percent = c["prog_c"].payload_len * 100.0 / total_payload


# the 10 here is because Trex doesnt like CPS under 0.5
# so we try to go up an order of magnitude
# since most users will just multiply this again with the global multiplier after
target_cps = c["l7_percent"] / payload_percent

c["cps"] = target_cps

if target_cps < lowest:
lowest = target_cps
percent_sum += c["l7_percent"]
if percent_sum != 100:
raise ASTFError("l7_percent values must sum up to 100")
# normalize it all so that lowest = 1
mult = 1 / lowest
for c in all_cap_info:
c["cps"] = c["cps"] * mult


for c in all_cap_info:
temp_c = ASTFTCPClientTemplate(program=c["prog_c"], glob_info=c["glob_c"], ip_gen=c["ip_gen"], port=c["d_port"],
Expand Down