Fix build failure in trex-emu-proxy
#27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Fixes following issues indicated by golangci-lint: cmd-proxy/trex-emu-proxy.go:33:2: field `port` is unused (unused) port *int ^ cmd-proxy/trex-emu-proxy.go:182:2: unreachable: unreachable code (govet) o.tctx.Veth.SimulatorCleanup() ^ No need for cleanups after the MainLoop since when the proxy process is terminated from shell the program will exit (no signal handling exist). Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error when attempting to build
trex-emu-proxywith:go install cmd-proxy/trex-emu-proxy.goThe API to get the timer channel changed via c870182 and the new API is now used.
Additionally the following issues, indicated by golangci-lint, are fixed:
No need for cleanups since when the process is terminated from shell it will exit in the MainLoop (no signal handling exist).