Skip to content

Commit e0f15d2

Browse files
ericsson-peiwuyangleomaatEric
authored andcommitted
change to camel case and adjust some names and add some annotations
1 parent 40ba892 commit e0f15d2

File tree

10 files changed

+414
-356
lines changed

10 files changed

+414
-356
lines changed

src/main/java/com/cisco/trex/stateful/TRexAstfClient.java

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@
1111
import java.util.stream.Collectors;
1212
import java.util.stream.StreamSupport;
1313

14+
import com.cisco.trex.stateful.model.stats.*;
1415
import com.cisco.trex.util.Constants;
1516
import org.apache.commons.lang3.StringUtils;
1617

1718
import com.cisco.trex.ClientBase;
18-
import com.cisco.trex.stateful.model.stats.AstfStatistics;
19-
import com.cisco.trex.stateful.model.stats.MetaData;
20-
import com.cisco.trex.stateful.model.stats.LatencyStats;
2119
import com.cisco.trex.stateless.exception.TRexConnectionException;
2220
import com.cisco.trex.stateless.model.ApiVersionHandler;
2321
import com.cisco.trex.stateless.model.PortStatus;
@@ -27,7 +25,7 @@
2725
import com.google.gson.JsonParser;
2826
import com.google.gson.JsonObject;
2927
import com.cisco.trex.stateful.model.stats.LatencyStats;
30-
import com.cisco.trex.stateful.model.stats.PortLatencyData;
28+
import com.cisco.trex.stateful.model.stats.LatencyPortData;
3129

3230
/**
3331
* TRex Astf Client class
@@ -355,19 +353,19 @@ public LatencyStats getLatencyStats() {
355353
Map<String, Object> payload = this.createPayload();
356354
String json = this.callMethod("get_latency_stats", payload);
357355
JsonElement response = new JsonParser().parse(json);
358-
JsonElement latencyStatsData = response.getAsJsonArray().get(0).getAsJsonObject().get("result");
359-
//only can parse a part of data, PortLatencyData need to be parsed manually.
360-
LatencyStats latencyStats = GSON.fromJson(latencyStatsData, LatencyStats.class);
361-
JsonElement dataElement = latencyStatsData.getAsJsonObject().get("data");
362-
JsonObject data = dataElement.getAsJsonObject();
363-
Map<Integer, PortLatencyData> portLatencyDataMap = new HashMap<>();
364-
// parse PortLatencyData manually
365-
for (Map.Entry<String, JsonElement> entry : data.entrySet()) {
356+
JsonElement latencyStatsJsonElement = response.getAsJsonArray().get(0).getAsJsonObject().get("result");
357+
//only can parse a part of data, LatencyPortData need to be parsed manually.
358+
LatencyStats latencyStats = GSON.fromJson(latencyStatsJsonElement, LatencyStats.class);
359+
JsonElement latencyDataJsonElement = latencyStatsJsonElement.getAsJsonObject().get("data");
360+
JsonObject latencyDataJsonObject = latencyDataJsonElement.getAsJsonObject();
361+
Map<Integer, LatencyPortData> portLatencyDataMap = new HashMap<>();
362+
// parse LatencyPortData manually
363+
for (Map.Entry<String, JsonElement> entry : latencyDataJsonObject.entrySet()) {
366364
String jsonKey = entry.getKey();
367365
if(jsonKey.startsWith("port")){
368-
Integer port = Integer.parseInt(jsonKey.substring(5));
369-
PortLatencyData portLatencyData = GSON.fromJson(entry.getValue(), PortLatencyData.class);
370-
portLatencyDataMap.put(port,portLatencyData);
366+
Integer portIndex = Integer.parseInt(jsonKey.substring(5));
367+
LatencyPortData latencyPortData = GSON.fromJson(entry.getValue(), LatencyPortData.class);
368+
portLatencyDataMap.put(portIndex, latencyPortData);
371369
}
372370
}
373371
latencyStats.getData().setPortLatencyDataMap(portLatencyDataMap);

src/main/java/com/cisco/trex/stateful/model/stats/HistogramData.java

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/main/java/com/cisco/trex/stateful/model/stats/LatencyData.java

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,56 @@
11
package com.cisco.trex.stateful.model.stats;
22

3-
import com.fasterxml.jackson.annotation.JsonProperty;
3+
import com.google.gson.annotations.SerializedName;
44

55
import java.util.Map;
66

77
public class LatencyData {
88

9-
@JsonProperty("cpu_util")
10-
public String cpu_util;
9+
@SerializedName("cpu_util")
10+
public String cpuUtil;
1111

12-
@JsonProperty("epoch")
12+
@SerializedName("epoch")
1313
public Integer epoch;
1414

15-
public Map<Integer, PortLatencyData> portLatencyDataMap;
15+
public Map<Integer, LatencyPortData> portLatencyDataMap;
1616

17-
@JsonProperty("unknown")
17+
@SerializedName("unknown")
1818
public Integer unknown;
1919

20-
public String getCpu_util() {
21-
return cpu_util;
20+
@SerializedName("cpu_util")
21+
public String getCpuUtil() {
22+
return cpuUtil;
2223
}
2324

24-
public void setCpu_util(String cpu_util) {
25-
this.cpu_util = cpu_util;
25+
@SerializedName("cpu_util")
26+
public void setCpuUtil(String cpuUtil) {
27+
this.cpuUtil = cpuUtil;
2628
}
2729

30+
@SerializedName("epoch")
2831
public Integer getEpoch() {
2932
return epoch;
3033
}
3134

35+
@SerializedName("epoch")
3236
public void setEpoch(Integer epoch) {
3337
this.epoch = epoch;
3438
}
3539

36-
public Map<Integer, PortLatencyData> getPortLatencyDataMap() {
40+
public Map<Integer, LatencyPortData> getPortLatencyDataMap() {
3741
return portLatencyDataMap;
3842
}
3943

40-
public void setPortLatencyDataMap(Map<Integer, PortLatencyData> portLatencyDataMap) {
44+
public void setPortLatencyDataMap(Map<Integer, LatencyPortData> portLatencyDataMap) {
4145
this.portLatencyDataMap = portLatencyDataMap;
4246
}
4347

48+
@SerializedName("unknown")
4449
public Integer getUnknown() {
4550
return unknown;
4651
}
4752

53+
@SerializedName("unknown")
4854
public void setUnknown(Integer unknown) {
4955
this.unknown = unknown;
5056
}
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
package com.cisco.trex.stateful.model.stats;
2+
3+
import com.google.gson.annotations.SerializedName;
4+
5+
public class LatencyPortData {
6+
7+
@SerializedName("hist")
8+
public LatencyPortHist hist;
9+
10+
@SerializedName("stats")
11+
public LatencyPortStats stats;
12+
13+
@SerializedName("hist")
14+
public LatencyPortHist getHist() {
15+
return hist;
16+
}
17+
18+
@SerializedName("hist")
19+
public void setHist(LatencyPortHist hist) {
20+
this.hist = hist;
21+
}
22+
23+
@SerializedName("stats")
24+
public LatencyPortStats getStats() {
25+
return stats;
26+
}
27+
28+
@SerializedName("stats")
29+
public void setStats(LatencyPortStats stats) {
30+
this.stats = stats;
31+
}
32+
}
Lines changed: 127 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
package com.cisco.trex.stateful.model.stats;
2+
3+
import com.google.gson.annotations.SerializedName;
4+
5+
import java.util.List;
6+
7+
public class LatencyPortHist {
8+
9+
private static class Histogram{
10+
@SerializedName("key")
11+
public Integer key;
12+
13+
@SerializedName("val")
14+
public Integer val;
15+
16+
@SerializedName("key")
17+
public Integer getKey() {
18+
return key;
19+
}
20+
21+
@SerializedName("key")
22+
public void setKey(Integer key) {
23+
this.key = key;
24+
}
25+
26+
@SerializedName("val")
27+
public Integer getVal() {
28+
return val;
29+
}
30+
31+
@SerializedName("val")
32+
public void setVal(Integer val) {
33+
this.val = val;
34+
}
35+
}
36+
37+
@SerializedName("cnt")
38+
public Integer cnt;
39+
40+
@SerializedName("high_cnt")
41+
public Integer highCnt;
42+
43+
@SerializedName("histogram")
44+
public List<Histogram> histogram;
45+
46+
@SerializedName("max_usec")
47+
public Integer maxUsec;
48+
49+
@SerializedName("min_usec")
50+
public Integer minUsec;
51+
52+
@SerializedName("s_avg")
53+
public Double sAvg;
54+
55+
@SerializedName("s_max")
56+
public Double sMax;
57+
58+
@SerializedName("cnt")
59+
public Integer getCnt() {
60+
return cnt;
61+
}
62+
63+
@SerializedName("cnt")
64+
public void setCnt(Integer cnt) {
65+
this.cnt = cnt;
66+
}
67+
68+
@SerializedName("high_cnt")
69+
public Integer getHighCnt() {
70+
return highCnt;
71+
}
72+
73+
@SerializedName("high_cnt")
74+
public void setHighCnt(Integer highCnt) {
75+
this.highCnt = highCnt;
76+
}
77+
78+
@SerializedName("histogram")
79+
public List<Histogram> getHistogram() {
80+
return histogram;
81+
}
82+
83+
@SerializedName("histogram")
84+
public void setHistogram(List<Histogram> histogram) {
85+
this.histogram = histogram;
86+
}
87+
88+
@SerializedName("max_usec")
89+
public Integer getMaxUsec() {
90+
return maxUsec;
91+
}
92+
93+
@SerializedName("max_usec")
94+
public void setMaxUsec(Integer maxUsec) {
95+
this.maxUsec = maxUsec;
96+
}
97+
98+
@SerializedName("min_usec")
99+
public Integer getMinUsec() {
100+
return minUsec;
101+
}
102+
103+
@SerializedName("min_usec")
104+
public void setMinUsec(Integer minUsec) {
105+
this.minUsec = minUsec;
106+
}
107+
108+
@SerializedName("s_avg")
109+
public Double getsAvg() {
110+
return sAvg;
111+
}
112+
113+
@SerializedName("s_avg")
114+
public void setsAvg(Double sAvg) {
115+
this.sAvg = sAvg;
116+
}
117+
118+
@SerializedName("s_max")
119+
public Double getsMax() {
120+
return sMax;
121+
}
122+
123+
@SerializedName("s_max")
124+
public void setsMax(Double sMax) {
125+
this.sMax = sMax;
126+
}
127+
}

0 commit comments

Comments
 (0)