Skip to content

Commit 2e81293

Browse files
committed
Sync with v2.60+
- jeromq update - gradle update to 4.2.1 - fixed responses handling (single instead of list handling) - fixed request empty params
1 parent b80ac59 commit 2e81293

File tree

8 files changed

+24
-10
lines changed

8 files changed

+24
-10
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ test {
4545
task uiTest(type: Test) {
4646
description 'Runs UI testing(E2E)'
4747
outputs.upToDateWhen { false }
48-
testClassesDir = sourceSets.uiTest.output.classesDir
48+
testClassesDirs = sourceSets.uiTest.output.classesDirs
4949
classpath = sourceSets.uiTest.runtimeClasspath
5050

5151
testLogging {
@@ -73,7 +73,7 @@ dependencies {
7373
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version:'2.6.0'
7474
compile group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-yaml', version:'2.5.4'
7575
compile group: 'org.json', name: 'json', version:'20150729'
76-
compile group: 'org.zeromq', name: 'jeromq', version:'0.4.0'
76+
compile group: 'org.zeromq', name: 'jeromq', version:'0.5.1'
7777
compile group: 'commons-io', name: 'commons-io', version:'2.4'
7878
compile group: 'commons-lang', name: 'commons-lang', version:'2.4'
7979
compile group: 'com.google.code.gson', name: 'gson', version:'2.7'
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Fri Feb 01 15:27:25 NOVT 2019
1+
#Tue Sep 10 13:45:42 NOVT 2019
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-2.13-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.2.1-bin.zip

src/main/java/com/exalttech/trex/core/ConnectionManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ public String sendRequest(String cmd, String parameters) {
247247
param = "{" + apiHParam + " , " + parameters + "}";
248248
}
249249

250+
} else {
251+
param = "{}";
250252
}
251253
String request = "{ \"id\" : \"aggogxls\", \"jsonrpc\" : \"2.0\", \"method\" : \"" + cmd + "\", \"params\" :" + param + " }";
252254
LOG.trace("Sending request \n" + Util.toPrettyFormat(request));

src/main/java/com/exalttech/trex/core/RPCCommands.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ private static String sendRequest(final String command, final Map<String, Object
5454
stringParameters = jsonParameters.substring(1, jsonParameters.length() - 1);
5555
}
5656
final String jsonRPCResult = ConnectionManager.getInstance().sendRequest(command, stringParameters);
57-
final RPCResponse[] rpcResult = new ObjectMapper().readValue(jsonRPCResult, RPCResponse[].class);
58-
final String specError = extractSpecError(rpcResult[0]);
57+
final RPCResponse rpcResult = new ObjectMapper().readValue(jsonRPCResult, RPCResponse.class);
58+
final String specError = extractSpecError(rpcResult);
5959
final String invalidHandlerErrorPart = "API handler provided mismatch";
6060

6161
if (specError.contains(invalidHandlerErrorPart)) {
6262
ConnectionManager.getInstance().notifyServerWasRestarted();
6363
}
6464

65-
return rpcResult[0].getResult();
65+
return rpcResult.getResult();
6666
}
6767

6868
private static String extractSpecError(final RPCResponse resp) {

src/main/java/com/exalttech/trex/core/RPCMethods.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ public String getSupportedCmds() {
377377
public Boolean pingRPCServer() {
378378
LOG.trace("Pinging RPC Server");
379379
try {
380-
serverConnectionManager.sendRPCRequest(Constants.PING_METHOD, null);
380+
serverConnectionManager.sendRPCRequest(Constants.PING_METHOD, new PingParams());
381381
LOG.trace("Ping OK");
382382
return true;
383383
} catch (JsonProcessingException | UnsupportedEncodingException | InvalidRPCResponseException | IncorrectRPCMethodException | NullPointerException | SizeLimitExceededException ex) {
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package com.exalttech.trex.remote.models.params;
2+
3+
public class PingParams extends Params {
4+
}

src/main/java/com/exalttech/trex/ui/PortsManager.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.exalttech.trex.ui.models.PortStatus;
2323
import com.exalttech.trex.util.Util;
2424
import com.fasterxml.jackson.databind.ObjectMapper;
25+
import com.fasterxml.jackson.databind.exc.MismatchedInputException;
2526
import org.apache.log4j.Logger;
2627

2728
import java.util.*;
@@ -159,7 +160,14 @@ public void updatedPorts(List<Integer> portIndexes) {
159160
if (response == null) {
160161
return;
161162
}
162-
List<PortStatus> portStatusList = mapper.readValue(response, mapper.getTypeFactory().constructCollectionType(List.class, PortStatus.class));
163+
List<PortStatus> portStatusList = new ArrayList<>();
164+
165+
try {
166+
portStatusList = mapper.readValue(response, mapper.getTypeFactory().constructCollectionType(List.class, PortStatus.class));
167+
} catch (MismatchedInputException ex) {
168+
portStatusList.add(mapper.readValue(response, mapper.getTypeFactory().constructType(PortStatus.class)));
169+
}
170+
163171
for (Port port : list) {
164172
PortStatus.PortStatusResult portStatus = portStatusList.get(list.indexOf(port)).getResult();
165173
port.setOwner(portStatus.getOwner());

src/main/java/com/exalttech/trex/ui/controllers/MainViewController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ private void loadSystemInfo() {
394394

395395
String versionResponse = ConnectionManager.getInstance().sendRequest("get_version", "");
396396
Gson gson = new Gson();
397-
JsonObject version = gson.fromJson(versionResponse, JsonArray.class).get(0).getAsJsonObject();
397+
JsonObject version = gson.fromJson(versionResponse, JsonObject.class);
398398
systemInfoReq.getResult().setApiVersion(version.getAsJsonObject("result").getAsJsonPrimitive("version").getAsString());
399399
LogsController.getInstance().appendText(LogType.INFO, "Loading port information complete");
400400
}

0 commit comments

Comments
 (0)