Reverted form argument in onError

Breaks existing code that updates stores. Wait until v3 for this feature.

Author: ciscoheat

CHANGELOG.md

@@ -10,7 +10,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Exported `ClientValidationAdapter` from `sveltekit-supoerforms/adapters`.
-- `form` is now available as an argument in [onError](https://superforms.rocks/concepts/events#onerror), so it can be modified as in `onUpdate`.
 
 ### Fixed
 

src/lib/client/superForm.ts

@@ -144,7 +144,6 @@ export type FormOptions<
 	onError:
 		| 'apply'
 		| ((event: {
-				form: SuperValidated<T, M, In>;
 				result: {
 					type: 'error';
 					status?: number;
@@ -1495,6 +1494,9 @@ export function superForm<
 				if (options.applyAction && pageUpdate.form && typeof pageUpdate.form === 'object') {
 					const actionData = pageUpdate.form;
 
+					// If actionData is an error, it's sent here from triggerOnError
+					if (actionData.type === 'error') return;
+
 					for (const newForm of Context_findValidationForms(actionData)) {
 						const isInitial = initialForms.has(newForm);
 
@@ -1703,7 +1705,8 @@ export function superForm<
 				result: { type: 'error'; status?: number; error: any },
 				status: number
 			) {
-				const form: SuperValidated<T, M, In> = Form_capture(false);
+				// For v3, then return { form } as data in applyAction below:
+				//const form: SuperValidated<T, M, In> = Form_capture(false);
 
 				result.status = status;
 
@@ -1738,7 +1741,7 @@ export function superForm<
 						await applyAction({
 							type: 'failure',
 							status: Form_resultStatus(result.status),
-							data: { form }
+							data: result
 						});
 					}
 				}

src/routes/(v2)/v2/app-error/+page.svelte

@@ -12,7 +12,8 @@
 			console.log(e.result);
 			// @ts-expect-error Does not follow the App.Error shape
 			error = 'code' in e.result.error ? e.result.error.code : e.result.error.message;
-		}
+		},
+		taintedMessage: false
 	});
 
 	const { enhance, form } = spForm;

src/routes/(v2)/v2/issue-485/+page.svelte

@@ -13,10 +13,10 @@
 	const { form, errors, message, enhance, submit, submitting } = superForm(
 		defaults({ email: '[email protected]', name: 'aaa' }, zod(schema)),
 		{
-			onError({ result, form }) {
+			onError({ result }) {
 				console.log('=== onError ===');
 
-				form.message = JSON.stringify(result.error, null, 2);
+				$message = JSON.stringify(result.error, null, 2);
 
 				// Cast the error, as its type isn't unknown.
 				const error = result.error as unknown as {
@@ -25,7 +25,7 @@
 				} & Record<string, unknown>;
 
 				if (!defaultStatus) result.status = error.status;
-				form.errors = error.errors;
+				$errors = error.errors;
 			},
 			async onUpdate({ form, result }) {
 				console.log('=== onUpdate ===');
@@ -90,7 +90,7 @@
 	<br />
 	<input type="checkbox" bind:checked={shouldThrowIfNotSuccess} /> Throw if not success
 	<br />
-	<input type="checkbox" bind:checked={defaultStatus} /> Status 500 on error
+	<input type="checkbox" bind:checked={defaultStatus} /> Status 400 on error
 </div>
 
 {#if $message}