Updating the same variable to the same value prevented onChange.

Author: ciscoheat

CHANGELOG.md

@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Updating the same variable to the same value prevented the [onChange](https://superforms.rocks/concepts/events#onchange) event from being triggered.
 - Factorized [SuperDebug](https://superforms.rocks/super-debug) clipboard script
 
 ## [2.18.1] - 2024-09-13

src/lib/client/superForm.ts

@@ -1282,9 +1282,9 @@ export function superForm<
 					return currentlyTainted;
 				});
 			}
-		}
 
-		NextChange_setHtmlEvent({ paths });
+			NextChange_setHtmlEvent({ paths });
+		}
 	}
 
 	/**

src/routes/(v2)/v2/Navigation.svelte

@@ -64,7 +64,8 @@
 		'simple-tainted',
 		'validity-objects',
 		'issue-466',
-		'spa-error'
+		'spa-error',
+		'issue-470'
 	].sort();
 </script>
 

src/routes/(v2)/v2/issue-470/+page.server.ts

@@ -0,0 +1,21 @@
+import type { Actions, PageServerLoad } from './$types.js';
+
+import { superValidate, message } from '$lib/index.js';
+import { zod } from '$lib/adapters/zod.js';
+import { fail } from '@sveltejs/kit';
+import { schema } from './schema.js';
+
+export const load: PageServerLoad = async () => {
+	return { form: await superValidate(zod(schema)) };
+};
+
+export const actions: Actions = {
+	default: async ({ request }) => {
+		const form = await superValidate(request, zod(schema));
+		console.log(form);
+
+		if (!form.valid) return fail(400, { form });
+
+		return message(form, 'Form posted successfully!');
+	}
+};

src/routes/(v2)/v2/issue-470/+page.svelte

@@ -0,0 +1,42 @@
+<script lang="ts">
+	import { superForm } from '$lib/index.js';
+	import SuperDebug from '$lib/index.js';
+
+	export let data;
+
+	let changeEvent: unknown | undefined = undefined;
+	const { form } = superForm(data.form, {
+		onChange: (e) => {
+			changeEvent = e;
+		}
+	});
+
+	function setNumberTwice() {
+		const value = Math.random();
+		$form.value = value;
+		$form.value = value;
+	}
+	function setNumberOnce() {
+		const value = Math.random();
+		$form.value = value;
+	}
+</script>
+
+<SuperDebug data={$form} />
+
+<h3>Superforms testing ground - Zod</h3>
+
+<p>
+	Bug: If the same value is written twice, no change event is fired If first button is clicked, no
+	change event is fired (however the value is updated). If the second button is clicked a change
+	event is fired
+</p>
+
+<p>
+	Change event was:
+	<code>{JSON.stringify(changeEvent)}</code>
+</p>
+
+<button on:click={setNumberTwice}>Click me to set the same value twice</button>
+<button on:click={setNumberOnce}>Click me to set a value once</button>
+<button on:click={() => (changeEvent = undefined)}>Clear event</button>

src/routes/(v2)/v2/issue-470/schema.ts

@@ -0,0 +1,5 @@
+import { z } from 'zod';
+
+export const schema = z.object({
+	value: z.number().nullable()
+});