Fixed constraints on fields that starts with a number.

Fixes #285

Author: ciscoheat

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Timers weren't starting until after `onSubmit`, allowing multiple form submissions on longer async operations. ([#284](https://github.com/ciscoheat/sveltekit-superforms/issues/284))
+- Fixed constraints on fields that starts with a number. ([#285](https://github.com/ciscoheat/sveltekit-superforms/issues/285))
 
 ## [1.10.0] - 2023-11-07
 

src/lib/client/clientValidation.ts

@@ -133,7 +133,7 @@ async function _clientValidation<T extends AnyZodObject, M = unknown>(
 
       await traversePathsAsync(checkData, async ({ value, path }) => {
         // Filter out array indices, the validator structure doesn't contain these.
-        const validationPath = path.filter((p) => isNaN(parseInt(p)));
+        const validationPath = path.filter((p) => /\D/.test(String(p)));
         const maybeValidator = traversePath(
           validator,
           validationPath as FieldPath<typeof validator>
@@ -392,7 +392,7 @@ async function _validateField<T extends ZodValidation<AnyZodObject>, M>(
     shouldUpdate: true,
     currentData: undefined as z.infer<T> | undefined,
     // Remove numeric indices, they're not used for validators.
-    validationPath: path.filter((p) => isNaN(parseInt(p)))
+    validationPath: path.filter((p) => /\D/.test(String(p)))
   };
 
   async function defaultValidate() {

src/lib/client/proxies.ts

@@ -282,7 +282,7 @@ export function formFieldProxy<
   const path2 = splitPath<z.infer<UnwrapEffects<T>>>(path);
   // Filter out array indices, the constraints structure doesn't contain these.
   const constraintsPath = (path2 as unknown[])
-    .filter((p) => isNaN(parseInt(String(p))))
+    .filter((p) => /\D/.test(String(p)))
     .join('.');
 
   const taintedProxy = derived<

src/lib/errors.ts

@@ -88,7 +88,7 @@ export function mapErrors<T extends AnyZodObject>(
   for (const [key, value] of entries.filter(([key]) => key !== '_errors')) {
     // Keep current errorShape if the object key is numeric
     // which means we are in an array.
-    const numericKey = !isNaN(parseInt(key, 10));
+    const numericKey = /^\d+$/.test(key);
 
     // _errors are filtered out, so casting is fine
     output[key] = mapErrors(