Fixed client-side validation when taint option is false.

Author: ciscoheat

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - When cancelling a request, timers were cancelled too early in [SPA mode](https://superforms.rocks/concepts/spa) and when [client-side validation](https://superforms.rocks/concepts/client-validation) failed.
 - [Proxies](https://superforms.rocks/concepts/proxy-objects) didn't set or update a nested path unless it previously existed.
+- The when the [taint option](https://superforms.rocks/concepts/tainted#tainted-store) was set to `false`, client-side validation was prevented.
 
 ## [1.10.2] - 2023-11-14
 

src/lib/client/index.ts

@@ -695,13 +695,6 @@ export function superForm<
     compareAgainst: unknown,
     taintOptions: TaintOption<UnwrappedT>
   ) {
-    if (taintOptions === false) {
-      return;
-    } else if (taintOptions === 'untaint-all') {
-      Tainted.set(undefined);
-      return;
-    }
-
     let paths = comparePaths(newObj, compareAgainst);
 
     if (typeof taintOptions === 'object') {
@@ -715,17 +708,19 @@ export function superForm<
       taintOptions = true;
     }
 
-    if (taintOptions === true) {
-      LastChanges.set(paths);
-    }
+    LastChanges.set(paths);
 
     if (paths.length) {
-      Tainted.update((tainted) => {
-        //console.log('Update tainted:', paths, newObj, compareAgainst);
-        if (!tainted) tainted = {};
-        setPaths(tainted, paths, taintOptions === true ? true : undefined);
-        return tainted;
-      });
+      if (taintOptions === 'untaint-all') {
+        Tainted.set(undefined);
+      } else {
+        Tainted.update((tainted) => {
+          //console.log('Update tainted:', paths, newObj, compareAgainst);
+          if (!tainted) tainted = {};
+          setPaths(tainted, paths, taintOptions === true ? true : undefined);
+          return tainted;
+        });
+      }
 
       if (
         !(

src/routes/tests/array-component/+page.svelte

@@ -3,26 +3,23 @@
   import type { PageData } from './$types';
   import SuperDebug from '$lib/client/SuperDebug.svelte';
   import AutoComplete from './AutoComplete.svelte';
+  import { schema } from './schema';
 
   export let data: PageData;
 
   const pageForm = superForm(data.form, {
-    dataType: 'json'
-    //validators: schema
+    dataType: 'json',
+    validators: schema
   });
   const { form, errors, message, enhance, tainted } = pageForm;
 
   const options = [
     { value: 'A', label: 'Aldebaran' },
     { value: 'B', label: 'Betelgeuse' }
   ];
-
-  const { fieldErrors } = arrayProxy(pageForm, 'sub.tags');
 </script>
 
-<SuperDebug data={{ $form, $errors, $fieldErrors }} />
-
-{#if $tainted}<h3>FORM IS TAINTED</h3>{/if}
+{#if $tainted?.sub?.tags?.[0]}<h3>FORM IS TAINTED</h3>{/if}
 
 {#if $message}<h4>{$message}</h4>{/if}
 
@@ -33,6 +30,8 @@
   </div>
 </form>
 
+<SuperDebug data={{ $form, $errors, $tainted }} />
+
 <style lang="scss">
   form {
     margin: 2rem 0;