Missing boolean fields were valid in strict mode.

Author: ciscoheat

CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - A successful `PageData` result from `invalidateAll` was overwritten by the `ActionData` result.
 - Using `goto` in events didn't work when the target page redirected.
 - `FormPath` and `FormPathLeaves` didn't handle fields with type `unknown` and `any`.
+- Missing boolean fields were valid in strict mode.
 
 ## [2.5.0] - 2024-02-21
 

src/lib/formData.ts

@@ -149,12 +149,14 @@ function _parseFormData<T extends Record<string, unknown>>(
 	options?: SuperValidateOptions<T>
 ) {
 	const output: Record<string, unknown> = {};
-	const schemaKeys = new Set(
-		[
-			...Object.keys(schema.properties ?? {}),
-			...(schema.additionalProperties ? formData.keys() : [])
-		].filter((key) => !key.startsWith('__superform_'))
-	);
+	const schemaKeys = options?.strict
+		? new Set([...formData.keys()].filter((key) => !key.startsWith('__superform_')))
+		: new Set(
+				[
+					...Object.keys(schema.properties ?? {}),
+					...(schema.additionalProperties ? formData.keys() : [])
+				].filter((key) => !key.startsWith('__superform_'))
+			);
 
 	function parseSingleEntry(key: string, entry: FormDataEntryValue, info: SchemaInfo) {
 		if (options?.preprocessed && options.preprocessed.includes(key as keyof T)) {
@@ -246,7 +248,7 @@ function parseFormDataEntry(
 	info: SchemaInfo
 ): unknown {
 	if (!value) {
-		//console.log(`No FormData for "${key}" (${type}).`, info); //debug
+		//console.log(`No FormData for "${key}" (${type}).`, info, strict); //debug
 
 		// Special case for booleans with default value true
 		if (type == 'boolean' && info.isOptional && info.schema.default === true) {

src/tests/legacy/strict.test.ts

@@ -29,6 +29,38 @@ describe('Strict mode', () => {
 		expect(form.valid).toEqual(true);
 	});
 
+	describe('Should not allow missing boolean fields', () => {
+		test('With FormData', async () => {
+			const formData = new FormData();
+
+			const schema = z.object({
+				enabled: z.boolean()
+			});
+
+			const form = await superValidate(formData, zod(schema), {
+				strict: true
+			});
+
+			expect(form.valid).toBe(false);
+			expect(form.errors).toEqual({ enabled: ['Required'] });
+		});
+
+		test('With an object', async () => {
+			const data = {};
+
+			const schema = z.object({
+				enabled: z.boolean()
+			});
+
+			const form = await superValidate(data, zod(schema), {
+				strict: true
+			});
+
+			expect(form.valid).toBe(false);
+			expect(form.errors).toEqual({ enabled: ['Required'] });
+		});
+	});
+
 	const strictTests = [
 		{
 			name: 'Should be invalid if foo is not present in object',