Fixes #195

Boolean fields with a default value of true always returned true when validating.

Author: ciscoheat

CHANGELOG.md

@@ -7,7 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- Fixed #143, infinite deep type instantiation on `message`. (Thanks to [thelinuxlich](https://github.com/thelinuxlich))
+### Fixed
+
+- Boolean fields with a default value of `true` always returned `true` when validating.
+- Fixed infinite deep type instantiation on `message`. (#143, thanks to [Alisson Cavalcante Agiani](https://github.com/thelinuxlich))
+- Fixed typesVersions map that caused incorrect auto-import paths (#191, thanks to [CokaKoala](https://github.com/AdrianGonz97))
 
 ## [1.0.0]
 

src/lib/superValidate.ts

@@ -137,12 +137,14 @@ function formDataToValidation<T extends AnyZodObject>(
     typeInfo: ZodTypeInfo
   ): unknown {
     const newValue = valueOrDefault(value, false, true, typeInfo);
+    const zodType = typeInfo.zodType;
 
     // If the value was empty, it now contains the default value,
-    // so it can be returned immediately
-    if (!value) return newValue;
-
-    const zodType = typeInfo.zodType;
+    // so it can be returned immediately, unless it's boolean, which
+    // means it could have been posted as a checkbox.
+    if (!value && zodType._def.typeName != 'ZodBoolean') {
+      return newValue;
+    }
 
     if (zodType._def.typeName == 'ZodString') {
       return value;
@@ -182,14 +184,14 @@ function formDataToValidation<T extends AnyZodObject>(
       return value;
     } else if (zodType._def.typeName == 'ZodNativeEnum') {
       const zodEnum = zodType as ZodNativeEnum<EnumLike>;
-      if (value in zodEnum.enum) {
+      if (value !== null && value in zodEnum.enum) {
         const enumValue = zodEnum.enum[value];
         if (typeof enumValue === 'number') return enumValue;
         else if (enumValue in zodEnum.enum) return zodEnum.enum[enumValue];
       }
       return undefined;
     } else if (zodType._def.typeName == 'ZodSymbol') {
-      return Symbol(value);
+      return Symbol(String(value));
     }
 
     throw new SuperFormError(

src/routes/tests/issue-195/+page.server.ts

@@ -0,0 +1,26 @@
+import type { Actions, PageServerLoad } from './$types';
+import { message, superValidate } from '$lib/server';
+import { schema } from './schema';
+import { fail } from '@sveltejs/kit';
+
+export const load = (async () => {
+  const form = await superValidate(schema);
+  return { form };
+}) satisfies PageServerLoad;
+
+export const actions = {
+  default: async ({ request }) => {
+    const formData = await request.formData();
+    console.log(
+      '🚀 ~ file: +page.server.ts:14 ~ default: ~ formData:',
+      formData
+    );
+    const form = await superValidate(formData, schema);
+
+    console.log('POST', form);
+
+    if (!form.valid) return fail(400, { form });
+
+    return message(form, 'Posted OK!');
+  }
+} satisfies Actions;

src/routes/tests/issue-195/+page.svelte

@@ -0,0 +1,41 @@
+<script lang="ts">
+  import { superForm } from '$lib/client';
+  import type { PageData } from './$types';
+  import SuperDebug from '$lib/client/SuperDebug.svelte';
+  import { schema } from './schema';
+
+  export let data: PageData;
+
+  const { form, errors, tainted, message, enhance } = superForm(data.form, {
+    //dataType: 'json',
+    //validators: schema
+  });
+</script>
+
+<SuperDebug data={{ $form, $errors, $tainted }} />
+
+{#if $message}<h4>{$message}</h4>{/if}
+
+<form method="POST">
+  <label class="flex items-center space-x-2">
+    <input
+      type="checkbox"
+      class="checkbox"
+      id="emaillist"
+      name="emaillist"
+      bind:checked={$form.emaillist}
+    /> Emaillist
+  </label>
+
+  <button>Submit</button>
+</form>
+
+<style lang="scss">
+  form {
+    margin: 2rem 0;
+
+    input {
+      background-color: #dedede;
+    }
+  }
+</style>

src/routes/tests/issue-195/schema.ts

@@ -0,0 +1,5 @@
+import { z } from 'zod';
+
+export const schema = z.object({
+  emaillist: z.boolean().optional().default(true)
+});