Tainted form example appears to break the browser history stack

[fnimick]

I have confirmed this behavior in desktop Firefox and Chrome. I'm not sure whether this is a problem with this specific example, or tainted form handling more broadly, but I have looked at the example and can see no special case behavior causing this.

To reproduce:

Navigate to the tainted form field example page, then to another page, then back.

Observe the state of the history stack. In my case:
Back stack:

Forward stack:

Then, attempt to navigate back from the tainted form, and click "confirm" on the modal.

Observe that rather than navigating back, instead the most recent history page has been navigated forward to, adding a new entry to the back stack. The forward stack has been cleared and is now empty.

[ciscoheat]

I may have a fix for this, can you fork this repo, start the dev server and go to http://localhost:5173/v2/simple-tainted or http://localhost:5173/v2/tainted-history to see if you can replicate it?

If you can, checkout the "issue-658-fix" branch and see if it's fixed.

[fnimick]

I couldn't replicate on simple-tainted but on tainted-history I confirmed that the branch fixed the issue.

EDIT: I was able to replicate on both.

EDIT: it might be worth confirming that it works with custom functions as well as messages, though.

[fnimick]

I've confirmed that custom functions don't work. Try the following:
in simple-tainted add the following to the superForm constructor:

		taintedMessage: async () => {
			return confirm('test');
		}

Then, navigate to simple-tainted from another page. On clicking back, accept the prompt. It doesn't navigate away at all anymore. Then, click back and it navigates away with no prompt this time.