Skip to content

Commit 1ad94f8

Browse files
author
hp23 Server
committed
Minor fixes
1 parent ef81a46 commit 1ad94f8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ By slightly adapting the configuration and updating the used browsers, it is als
3535
- Run all basic tests: `for i in {1..5}; do poetry run python desktop_selenium.py --num_browsers 50 --resp_type basic; done`
3636
- Run all parsing tests: `for i in {1..5}; do poetry run python desktop_selenium.py --num_browsers 50 --resp_type parsing; done`
3737
- It can happen that some tests do not have 5 results after the above commands due to timeouts and similar, to ensure that all tests have at least 5 results run the below commands.
38-
- Run missing basic tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'basic' and \"Browser\".os = 'Ubuntu 22.04'` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
39-
- Run missing parsing tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'parsing' and \"Browser\".os = 'Ubuntu 22.04'` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
38+
- Run missing basic tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'basic' and \"Browser\".os = 'Ubuntu 22.04'"` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
39+
- Run missing parsing tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'parsing' and \"Browser\".os = 'Ubuntu 22.04'"` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
4040
- To reproduce the results of the second experiment run with newer browsers, add `--new_browsers`
4141
- To run our tests on newer browsers, adjust the browser config in `desktop_selenium.py`
4242
- Optional configuration to debug headfull browsers on the Ubuntu container:

_hp/hp/tools/crawler/desktop_selenium.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ def unraisable_hook(unraisable):
455455
test_urls = get_tests(resp_type=args.resp_type, browser_id=browser_id, scheme=scheme, max_resps=args.max_resps, max_popups=args.max_popups)
456456
page_timeout = TIMEOUT
457457
elif args.run_mode == "repeat":
458-
with open("../repeat.json", "r") as f:
458+
with open("repeat.json", "r") as f:
459459
test_urls = json.load(f).get(str(browser_id), [])
460460
test_urls = list(filter(lambda s: s.startswith(f"{scheme}://"), test_urls))
461461
# Increased timeout for repeat tests

0 commit comments

Comments
 (0)