Skip to content

Commit 62e1129

Browse files
author
hp23 Server
committed
Update browser versions
1 parent 0fa0c7e commit 62e1129

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ By slightly adapting the configuration and updating the used browsers, it is als
3737
- It can happen that some tests do not have 5 results after the above commands due to timeouts and similar, to ensure that all tests have at least 5 results run the below commands.
3838
- Run missing basic tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'basic' and \"Browser\".os = 'Ubuntu 22.04'` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
3939
- Run missing parsing tests: `poetry run python create_repeat.py --selection_str "\"Response\".resp_type = 'parsing' and \"Browser\".os = 'Ubuntu 22.04'` and `poetry run python desktop_selenium.py --num_browsers 50 --run_mode repeat --max_urls_until_restart 50`
40+
- To reproduce the results of the second experiment run with newer browsers, add `--new_browsers`
41+
- To run our tests on newer browsers, adjust the browser config in `desktop_selenium.py`
4042
- Optional configuration to debug headfull browsers on the Ubuntu container:
4143
```bash
4244
Xvfb :99 -screen 0 1920x1080x24 &

_hp/hp/tools/crawler/desktop_selenium.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,8 @@ def unraisable_hook(unraisable):
341341
parser.add_argument("--gen_page_runner", action="store_true", help="Toggle the generate test-page-runner mode.")
342342
parser.add_argument("--gen_multiplier", default=1, type=int, help="How often to include each URL in the test-page-runner page.")
343343
parser.add_argument("--page_runner_json", default="", type=str, help="Path to a json list of generated test-page-runner URLs to visit")
344+
parser.add_argument("--new_browsers", action="store_true",
345+
help="Toggle on to use the set of newer browsers")
344346
args = parser.parse_args()
345347

346348
# Browser Config:
@@ -384,8 +386,6 @@ def unraisable_hook(unraisable):
384386
# Released 2023-02-20
385387
("firefox", "123", None, ["-headless"], get_or_create_browser("firefox", "123", "Ubuntu 22.04", "headless", "selenium", "")),
386388

387-
388-
389389
# Brave (setup for a concrete version managed manually)
390390
# mkdir ~/brave-versions
391391
# mkdir ~/brave-versions/brave-version
@@ -397,7 +397,16 @@ def unraisable_hook(unraisable):
397397
("brave", "121", "/home/ubuntu/brave-versions/v1.62.156/brave-browser",
398398
["--headless=new"], get_or_create_browser("brave", "v1.62.156 (121.0.6167.139)", "Ubuntu 22.04", "headless-new", "selenium", "")),
399399
]
400-
400+
if args.new_browsers:
401+
config = [
402+
# Released 2024-11-06
403+
("chrome", "131", None, ["--headless=new"], get_or_create_browser("chrome", "131", "Ubuntu 22.04", "headless-new", "selenium", "")),
404+
# Released 2024-11-26
405+
("firefox", "133", None, ["-headless"], get_or_create_browser("firefox", "133", "Ubuntu 22.04", "headless", "selenium", "")),
406+
# Released 2024-12-11
407+
("brave", "131", "/home/ubuntu/brave-versions/v1.73.101/brave-browser",
408+
["--headless=new"], get_or_create_browser("brave", "v1.73.101 (Chromium 131.0.6778.139)", "Ubuntu 22.04", "headless-new", "selenium", "")),
409+
]
401410
if args.debug_browsers:
402411
config = [
403412
# Configure browsers to use for debug runs manually here

0 commit comments

Comments
 (0)