Skip to content

Commit 741713a

Browse files
committed
Remove OAC fully
1 parent bc4cc9f commit 741713a

File tree

8 files changed

+1
-104
lines changed

8 files changed

+1
-104
lines changed

_hp/common/frame-oac.html

Lines changed: 0 additions & 28 deletions
This file was deleted.

_hp/common/frame-oac.html.headers

Lines changed: 0 additions & 2 deletions
This file was deleted.

_hp/hp/tools/analysis/response_header_generation.ipynb

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,45 +1034,6 @@
10341034
"ht.create_all_tests()"
10351035
]
10361036
},
1037-
{
1038-
"cell_type": "code",
1039-
"execution_count": 56,
1040-
"id": "ba87688e-2d86-497d-b1f6-4bfa29050e64",
1041-
"metadata": {},
1042-
"outputs": [
1043-
{
1044-
"name": "stdout",
1045-
"output_type": "stream",
1046-
"text": [
1047-
"1711\n",
1048-
"Created: 1699\n",
1049-
"[([('origin-agent-cluster', '?1')], 'OAC', 200, 'parsing'), ([('x-origin-agent-cluster', '?1')], 'OAC', 200, 'parsing'), ([('origin-agent-cluster:', '?1')], 'OAC', 200, 'parsing'), ([('origin-age7nt-cluster', '?1')], 'OAC', 200, 'parsing'), ([('porigin-agent-cluster', '?1')], 'OAC', 200, 'parsing')]\n"
1050-
]
1051-
}
1052-
],
1053-
"source": [
1054-
"label = \"OAC\"\n",
1055-
"header_name = \"origin-agent-cluster\"\n",
1056-
"alt_names = [\"x-origin-agent-cluster\"]\n",
1057-
"block_values = [\"?1\"]\n",
1058-
"allow_values = [\"?0\"]\n",
1059-
"partial_values = []\n",
1060-
"legacy_values = []\n",
1061-
"# Always start with the empty value and then an INVALID value (e.g., \"INVALID\"), after that both valid and invalid values can be added\n",
1062-
"# We use the first two in `mult_headers_test`\n",
1063-
"basic_values = [\"\", \"INVALID\", \"null\", \"*\", URL_REP]\n",
1064-
"# https://wpt.fyi/results/html/browsers/origin/origin-keyed-agent-clusters?label=master&label=experimental&aligned&q=origin-agent-cluster\n",
1065-
"wpt_values = [\"?1\", \"?0\"]\n",
1066-
"# https://github.com/hen95/HTTPHeaderBrowserTesting\n",
1067-
"siewert_values = [] # OAC not tested\n",
1068-
"crawler_ninja_values = [] # OAC not tested\n",
1069-
"own_values = [\"1\", \"0\", \"true\", \"false\"]\n",
1070-
"other_values = basic_values + wpt_values + siewert_values + crawler_ninja_values + own_values\n",
1071-
"other_values = expand_urls(other_values)\n",
1072-
"ht = HeaderTests(label, header_name, alt_names, block_values, allow_values, partial_values, legacy_values, other_values)\n",
1073-
"ht.create_all_tests()"
1074-
]
1075-
},
10761037
{
10771038
"cell_type": "code",
10781039
"execution_count": 57,

_hp/hp/tools/crawler/desktop_selenium.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,6 @@ def run_task(browser_name, browser_version, binary_location, arguments, debug_in
188188
original_window = driver.current_window_handle
189189
# Visit all test_urls
190190
for url in test_urls:
191-
# Do not visit originAgentCluster URLs (feature removed from the tests)
192-
if "originAgentCluster" in url:
193-
continue
194191
try:
195192
# Position the window off-screen (necessary for macOS headfull mode, such that the device stays more or less usable)
196193
driver.set_window_position(-5000, 0)

_hp/hp/tools/crawler/utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
("framing.sub.html", "CSP-FA", 5, 0, 0), # Tests: 72 (8*9), 2
6060
("framing.sub.html", "CSPvsXFO", 5, 0, 0), # Tests: 72 (8*9), 2
6161
("fullscreen-api-pp.sub.html", "PP", 5, 0, 0), # Tests: 32 (8*4), 2
62-
("originAgentCluster-oac.sub.html", "OAC", 1, 1, 8), # Tests: 24 (8*3), 1
6362
("perfAPI-tao.sub.html", "TAO", 10, 0, 0), # Tests: 8 (8*1), 1
6463
("referrer-access-rp.sub.html", "RP", 10, 0, 8), # Tests: 16 (8*2), 1
6564
("script-execution-csp.sub.html", "CSP-SCRIPT", 10, 0, 0), # Tests: 16 (8*2), 1
@@ -76,7 +75,6 @@
7675

7776
# Some tests often need longer, thus we increase their timeouts with the following modifiers
7877
timeout_modifiers = {
79-
"OAC": 2,
8078
"RP": 2,
8179
"XFO": 2,
8280
"CSP-FA": 2,

_hp/hp/tools/create_repeat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def calc_repeat(selection_str, mult_resp_ids):
2828
"Browser".name, "Browser".version, "Browser".headless_mode, "Browser".os, "Browser".automation_mode, "Browser".add_info
2929
FROM "Result"
3030
JOIN "Response" ON "Result".response_id = "Response".id JOIN "Browser" ON "Result".browser_id = "Browser".id
31-
WHERE "Browser".name != 'Unknown' and "Response".resp_type != 'debug' and test_status = 0
31+
WHERE "Browser".name != 'Unknown' and "Response".resp_type != 'debug' and test_status = 0 and "Response".label != 'OAC'
3232
and {selection_str};
3333
"""
3434
df = get_data(Config(), initial_data)

_hp/hp/tools/create_responses.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -318,33 +318,6 @@ def create_responses(header_list, label, status_code=200, resp_type="debug"):
318318
create_responses(header_list, label, status_code=302, resp_type="basic")
319319
#endregion
320320

321-
#region originAgentCluster/oac header
322-
# related to document.domain and site/origin isolation
323-
label = "OAC"
324-
header_name = "origin-agent-cluster" # https://html.spec.whatwg.org/multipage/browsers.html#origin-agent-cluster
325-
v1 = "?1"
326-
v2 = "?0"
327-
v3 = ""
328-
v4 = "1"
329-
v5 = "0"
330-
v6 = "true"
331-
v7 = "false"
332-
header_deny = [(header_name, v1)] # Set OAC, secure value
333-
header_allow = [(header_name, v2)] # Disable OAC, insecure value
334-
create_responses([header_deny, header_allow], label)
335-
header_list = [[(header_name, "*")], [],
336-
[(header_name, "null")], [(header_name, v1)],
337-
[(header_name, v2)], [(header_name, v3)],
338-
[(header_name, v4)], [(header_name, v5)],
339-
[(header_name, v6)], [(header_name, v7)],
340-
[(header_name, f"{v1}, {v2}, {v3}, {v4}, {v5}, {v6}, {v7}")],
341-
[(header_name, f"abc, {v1}")]
342-
]
343-
create_responses(header_list, label, resp_type="basic")
344-
# Some basic headers with redirect
345-
header_list = [[(header_name, v1), redirect_empty], [(header_name, v2), redirect_empty]]
346-
create_responses(header_list, label, status_code=302, resp_type="basic")
347-
#endregion
348321

349322
#region Permission access/PP
350323
# https://github.com/w3c/webappsec-permissions-policy/blob/main/features.md

_hp/server/responses.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ def get_body(feature_group, resp):
5858
file = open("_hp/common/swag.jpg", "rb")
5959
elif feature_group in ["framing"]:
6060
file = open("_hp/common/iframes.html", "rb")
61-
elif feature_group in ["oac"]:
62-
file = open("_hp/common/frame-oac.html", "rb")
6361
elif feature_group in ["csp-script"]:
6462
file = open("_hp/common/frame-script-csp.html", "rb")
6563
elif feature_group in ["csp-img"]:

0 commit comments

Comments
 (0)