Node Router get file : no device found

[use4me]

What happened?

It is no longer possible to use screenshot-basic with requestClientScreenshot, for example, because I cannot access the image that is sent in POST.

Expected result

Error: Access to this API has been restricted. Use -- allow-fs-write to manage permissions. Filesystem permission check from 'screenshot-basic' for permission fs.read on resource 'C:\Users\mathe\AppData\Local\Temp\upload_a955ca4254a78093bdb4409bB4c134c' - no device found

Reproduction steps

Use :

exports['screenshot-basic'].requestClientScreenshot(
	source,
	{
		fileName: path.join(savePath, filename + '.png'),
		encoding: 'png',
		quality: 1.0,
	},
	async (err, fileName) => {
		let image = await imagejs.Image.load(fileName);
		const coppedImage = image.crop({ x: image.width / 4.5, width: image.height });
		image.data = coppedImage.data;
		image.width = coppedImage.width;
		image.height = coppedImage.height;
		for (let x = 0; x < image.width; x++) {
			for (let y = 0; y < image.height; y++) {
				const pixelArr = image.getPixelXY(x, y);
				const r = pixelArr[0];
				const g = pixelArr[1];
				const b = pixelArr[2];
				if (g > r + b) {
					image.setPixelXY(x, y, [255, 255, 255, 0]);
				}
			}
		}
		image.save(fileName);
	}
);```

I have already 
```cfg
add_unsafe_child_process_permission fivem-greenscreener
add_unsafe_worker_permission fivem-greenscreener

add_filesystem_permission fivem-greenscreener write fivem-greenscreener

add_unsafe_child_process_permission screenshot-basic
add_unsafe_worker_permission screenshot-basic

add_filesystem_permission screenshot-basic write screenshot-basic

Importancy

Unknown

Area(s)

FXServer

Specific version(s)

Server 26389 Windows

Additional information

https://github.com/citizenfx/screenshot-basic/blob/5e89d4afb3e28b490344e84b5e2b5ac8cc5d9c75/src/server/server.ts#L22

[dug]

replace your savePath with GET_RESOURCE_PATH native to follow node sandboxing

[use4me]

This is already in my ResourcePath.

const resName = GetCurrentResourceName();
const mainSavePath = path.join(GetResourcePath(resName), 'images');

try {
	if (!fs.existsSync(mainSavePath)) {
		fs.mkdirSync(mainSavePath);
	}

	onNet('takeScreenshot', async (filename, type) => {
		const savePath = path.join(mainSavePath, type);
		if (!fs.existsSync(savePath)) {
			fs.mkdirSync(savePath);
		}
		exports['screenshot-basic'].requestClientScreenshot(
			source,
			{
				fileName: path.join(savePath, filename + '.png'),
				encoding: 'png',
				quality: 1.0,
			},
			async (err, fileName) => {
				let image = await imagejs.Image.load(fileName);
				const coppedImage = image.crop({ x: image.width / 4.5, width: image.height });
				image.data = coppedImage.data;
				image.width = coppedImage.width;
				image.height = coppedImage.height;

				for (let x = 0; x < image.width; x++) {
					for (let y = 0; y < image.height; y++) {
						const pixelArr = image.getPixelXY(x, y);
						const r = pixelArr[0];
						const g = pixelArr[1];
						const b = pixelArr[2];

						if (g > r + b) {
							image.setPixelXY(x, y, [255, 255, 255, 0]);
						}
					}
				}

				image.save(fileName);
			}
		);
	});
} catch (error) {
	console.error(error.message);
}

The error is on the upload of the file.
I get the file path of the uploaded file : https://github.com/citizenfx/screenshot-basic/blob/5e89d4afb3e28b490344e84b5e2b5ac8cc5d9c75/src/server/server.ts#L38

const f = ctx.request.files['file'] as File;

[gtolontop]

Heyy, I think the issue is that the Node.js filesystem sandbox doesn't have any VFS device mounted for the OS temp directory. When koa-body/formidable saves an uploaded file to %TEMP%, both the write and the subsequent read are denied with "no device found". I provide this fix he allows filesystem access to temp_directory_path() in the permission callback, before the VFS device lookup.