fix(watcher): resource version not updated

Author: michelesr

schedule_scaling/main.py

@@ -190,17 +190,17 @@ def scale_hpa(
         else:
             logging.error("API error patching HPA %s/%s: %s", namespace, name, e)
 
-def process_watch_event(ds: DeploymentStore, event: dict) -> None:
+def process_watch_event(ds: DeploymentStore, event: dict) -> str:
     obj: dict | V1Deployment = event["object"]
     event_type = event["type"]
 
     # some events (e.g. BOOKMARK) return a dict
     if isinstance(obj, dict):
         last_resource_version = obj["metadata"]["resourceVersion"]
     else:
-        last_resource_version = cast(
+        last_resource_version = cast(str, cast(
             V1ObjectMeta, obj.metadata
-        ).resource_version
+        ).resource_version)
     logging.debug(f"watch last_resource_version -> {last_resource_version}")
 
     match event_type:
@@ -228,6 +228,8 @@ def process_watch_event(ds: DeploymentStore, event: dict) -> None:
         case _:
             logging.debug(f"watch {event_type} {obj}")
 
+    return last_resource_version
+
 
 
 def watch_deployments(ds: DeploymentStore) -> None:
@@ -259,7 +261,7 @@ def watch_deployments(ds: DeploymentStore) -> None:
                     logging.warning(f"Skipping non dict event data: {event}")
                     continue
 
-                process_watch_event(ds, event)
+                last_resource_version = process_watch_event(ds, event)
 
                 logging.debug(f"Deployments: {ds.deployments}")
 

tests/test_unit.py

@@ -27,7 +27,9 @@ def ds():
     )
 
 
-def create_mock_event(event_type, name, namespace, annotations=None):
+def create_mock_event(
+    event_type, name, namespace, annotations=None, resource_version="123"
+):
     """Helper to create a mock watch event."""
     return {
         "type": event_type,
@@ -36,7 +38,7 @@ def create_mock_event(event_type, name, namespace, annotations=None):
                 name=name,
                 namespace=namespace,
                 annotations=annotations or {},
-                resource_version="123",
+                resource_version=resource_version,
             )
         ),
     }
@@ -74,6 +76,19 @@ def test_get_delta_sec_not_triggered():
     assert delta == 90
 
 
+def test_process_event_returns_resource_version(ds):
+    schedule_json = '[{"schedule": "0 9 * * *", "replicas": 5}]'
+    event = create_mock_event(
+        "ADDED",
+        "app-1",
+        "default",
+        {"zalando.org/schedule-actions": schedule_json},
+        resource_version="12345",
+    )
+
+    assert process_watch_event(ds, event) == "12345"
+
+
 def test_process_event_added_with_schedule(ds):
     schedule_json = '[{"schedule": "0 9 * * *", "replicas": 5}]'
     event = create_mock_event(