Skip to content

Commit af9b167

Browse files
Gürkan İndibayhanefi
andauthored
Apply suggestions from code review
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
1 parent 8440ee4 commit af9b167

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ assignees: gurkanindibay
1010
# Update OS Packages
1111
## Debian and RedHat
1212
- Change your directory to `packaging` repository directory & checkout `all-enterprise` branch.
13-
- [ ] Run the pipeline using branch name as all-enterprise https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want
13+
- [ ] Run [this pipeline](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml) using branch name as `all-enterprise`. Input tag name and if version is fancy, input the fancy version number. Other parameters could be kept as is if you want.
1414
- Then check the following (needed for both debian & redhat):
1515
- [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1`
1616
- Then check the following (needed for debian):
1717
- [ ] A new entry (`$VERSION.citus-1`, `stable`) is added to the `debian/changelog` file
1818
- Then check the following (needed for redhat):
19-
- [ ] `$PROJECT.spec` file is updated:
19+
- [ ] `citus.spec` file is updated:
2020
- [ ] `Version:` field
2121
- [ ] `Source0:` field
2222
- [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section
@@ -28,14 +28,13 @@ https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970
2828
## Microsoft Packages
2929

3030
- [ ] Add vso (Visual Studio Online) remote to your local git checkout of the github packaging repo (only needed once):
31-
`git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging`
31+
`git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging`
3232
- [ ] To trigger a test build on Azure DevOps:
3333
`git checkout all-enterprise`
3434
`git pull # from normal github origin`
3535
`git push vso # update Azure DevOps mirror`
36-
- [ ] Go here: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary
37-
- [ ] Wait for build to succeed. If build does not success, go here:
38-
https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018.
36+
- [ ] Open [ADO pipeline page](https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary)
37+
- [ ] Wait for build to succeed. If build does not success, go [here](https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018)
3938
Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link.
4039
- [ ] Check that it created the right packages by looking at the logs and artifacts (the button with the box/drawer icon and text “8 published”).
4140
- [ ] Click there, and see 7 items in signed packages
@@ -46,11 +45,11 @@ Maybe you need to update some parameters there (like the tools repo version). Th
4645
- [ ] Go back to the overview: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary
4746
- [ ] Click “Run pipeline”
4847
- [ ] Click “Variables”
49-
- [ ] Change PUBLISH_TO_PACKAGE_REPO to “true”
48+
- [ ] Change `PUBLISH_TO_PACKAGE_REPO` to “true”
5049
- [ ] Go back after doing so and click "Run”
5150
- [ ] Wait until completed.
5251
- [ ] Check if packages are successfully published using below links:
53-
- [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/
54-
- [ ] 4 new items for the version for Debian (buster and stretch): https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected)
55-
- [ ] 2 new items for the version for CentOS7/RHEL7: https://packages.microsoft.com/yumrepos/citus-centos7/
56-
- [ ] 2 new items for the version for CentOS8/RHEL8: https://packages.microsoft.com/yumrepos/citus-centos8/
52+
- [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): [here](https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/)
53+
- [ ] 4 new items for the version for Debian (buster and stretch): [here](https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/) ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected)
54+
- [ ] 2 new items for the version for CentOS7/RHEL7: [here](https://packages.microsoft.com/yumrepos/citus-centos7/)
55+
- [ ] 2 new items for the version for CentOS8/RHEL8: [here](https://packages.microsoft.com/yumrepos/citus-centos8/)

0 commit comments

Comments
 (0)