fix lint

Author: giornetta

.golangci.yml

@@ -0,0 +1,46 @@
+# golangci-lint v2 configuration
+# See https://golangci-lint.run/docs/configuration/ for full options
+
+version: "2"
+
+linters:
+  enable:
+    - errcheck
+    - govet
+    - misspell
+    - revive
+
+  settings:
+    errcheck:
+      # Don't check error returns for these functions
+      exclude-functions:
+        - (*net/http.Response.Body).Close
+        - (net/http.ResponseWriter).Write
+
+    revive:
+      rules:
+        # Disable overly strict rules
+        - name: exported
+          disabled: true
+        - name: package-comments
+          disabled: true
+        - name: unexported-return
+          disabled: true
+
+  exclusions:
+    # Enable predefined exclusion presets
+    presets:
+      - std-error-handling
+      - common-false-positives
+
+    # Custom exclusion rules
+    rules:
+      # Exclude errcheck for deferred Close() calls
+      - linters:
+          - errcheck
+        text: Error return value of.*\.Close.* is not checked
+
+formatters:
+  enable:
+    - gofmt
+    - goimports

disk_image_test.go

@@ -6,14 +6,6 @@ import (
 	"time"
 )
 
-func TestClienterDiskImage(t *testing.T) {
-	var c Clienter
-
-	c, _ = NewClient("foo", "NYC1")
-	c, _ = NewFakeClient()
-	_, _ = c.ListDiskImages()
-}
-
 func TestGetDiskImage(t *testing.T) {
 	client, server, _ := NewClientForTesting(map[string]string{
 		"/v2/disk_images/b82168fe-66f6-4b38-a3b8-5283542d5475": `{

errors.go

@@ -1060,7 +1060,7 @@ func decodeError(err error) error {
 			err := errors.New(msg.String())
 			return KubernetesClusterInvalidNameError.wrap(err)
 		default:
-			err := fmt.Errorf(fmt.Sprintf("Unknown error response - status: %s, code: %d, reason: %s", errorData.Status, errorData.Code, errorData.Reason))
+			err := fmt.Errorf("unknown error response - status: %s, code: %d, reason: %s", errorData.Status, errorData.Code, errorData.Reason)
 			return CommonError.wrap(err)
 		}
 	}

fake_client_test.go

@@ -10,10 +10,12 @@ import (
 func TestClienter(t *testing.T) {
 	var c Clienter
 
-	c, _ = NewClient("foo", "NYC1")
-	c, _ = NewFakeClient()
-	_, _ = c.ListAllInstances()
-	c.ListIPs()
+	c, err := NewClient("foo", "NYC1")
+	if err != nil {
+		t.Fail()
+	}
+
+	_ = c
 }
 
 // TestIPs is a test for the IPs method.
@@ -60,7 +62,11 @@ func TestInstances(t *testing.T) {
 		Count:    1,
 		Hostname: "foo.example.com",
 	}
-	client.CreateInstance(config)
+	_, err := client.CreateInstance(config)
+	if err != nil {
+		t.Errorf("Request returned an error: %s", err)
+		return
+	}
 
 	results, err := client.ListInstances(1, 10)
 	if err != nil {

instance_size.go

@@ -22,7 +22,7 @@ type InstanceSize struct {
 	Selectable        bool   `json:"selectable,omitempty"`
 }
 
-// ListInstanceSizes returns all availble sizes of instances
+// ListInstanceSizes returns all available sizes of instances
 // TODO: Rename to Size because this return all size (k8s, vm, database, kfaas)
 func (c *Client) ListInstanceSizes() ([]InstanceSize, error) {
 	resp, err := c.SendGetRequest("/v2/sizes")

network.go

@@ -107,7 +107,9 @@ func (c *Client) GetDefaultNetwork() (*Network, error) {
 	}
 
 	networks := make([]Network, 0)
-	json.NewDecoder(bytes.NewReader(resp)).Decode(&networks)
+	if err := json.NewDecoder(bytes.NewReader(resp)).Decode(&networks); err != nil {
+		return nil, fmt.Errorf("could not decode networks: %w", err)
+	}
 	for _, network := range networks {
 		if network.Default {
 			return &network, nil

utils/random.go

@@ -2,7 +2,6 @@ package utils
 
 import (
 	"math/rand"
-	"time"
 )
 
 var adjectives = [...]string{
@@ -42,7 +41,5 @@ var nouns = [...]string{
 
 // RandomName generates a Heroku-style random name for instances/clusters/etc
 func RandomName() string {
-	rand.Seed(time.Now().Unix())
-
 	return adjectives[rand.Intn(len(adjectives))] + "-" + nouns[rand.Intn(len(nouns))]
 }