Cleanup

Author: cjappl

clang/lib/CodeGen/BackendUtil.cpp

@@ -992,7 +992,6 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
           });
 
     if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) {
-      fprintf(stderr, "Adding RealtimeSanitizerPass\n");
       PB.registerLoopOptimizerEndEPCallback(
         [](LoopPassManager &LPM, OptimizationLevel Level) {
           LPM.addPass(RealtimeSanitizerLoopPass());

compiler-rt/test/rtsan/bound_loop.cpp

@@ -5,9 +5,8 @@
 // RUN: %clangxx -fsanitize=realtime %s -o %t -O1
 // RUN: %run %t 2>&1 | FileCheck %s --allow-empty
 
-// TODO: this test is failing with O0, investigate why
-// xxx: %clangxx -fsanitize=realtime %s -o %t -O0
-// xxx: %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx -fsanitize=realtime %s -o %t -O0
+// RUN: %run %t 2>&1 | FileCheck %s --allow-empty
 
 // UNSUPPORTED: ios
 

llvm/include/llvm/Transforms/Instrumentation/RealtimeSanitizer.h

@@ -22,7 +22,6 @@
 #include "llvm/IR/PassManager.h"
 #include "llvm/Transforms/Scalar/LoopPassManager.h"
 
-
 namespace llvm {
 
 struct RealtimeSanitizerOptions {};
@@ -41,7 +40,6 @@ struct RealtimeSanitizerLoopPass : PassInfoMixin<RealtimeSanitizerLoopPass> {
   static bool isRequired() { return true; }
 };
 
-
 } // namespace llvm
 
 #endif // LLVM_TRANSFORMS_INSTRUMENTATION_REALTIMESANITIZER_H

llvm/lib/Transforms/Instrumentation/RealtimeSanitizer.cpp

@@ -63,15 +63,16 @@ RealtimeSanitizerPass::RealtimeSanitizerPass(
 
 PreservedAnalyses RealtimeSanitizerPass::run(Function &F,
                                              AnalysisManager<Function> &AM) {
-  PreservedAnalyses PA = PreservedAnalyses::all();
   if (F.hasFnAttribute(Attribute::SanitizeRealtime)) {
     insertCallAtFunctionEntryPoint(F, "__rtsan_realtime_enter");
     insertCallAtAllFunctionExitPoints(F, "__rtsan_realtime_exit");
-    PA = PreservedAnalyses::none();
+
+    PreservedAnalyses PA;
     PA.preserveSet<CFGAnalyses>();
+    return PA;
   }
 
-  return PA;
+  return PreservedAnalyses::all();
 }
 
 PreservedAnalyses RealtimeSanitizerLoopPass::run(Loop &L, LoopAnalysisManager &AM, LoopStandardAnalysisResults &AR, LPMUpdater &U) {