Skip to content

wip: Add validator for null form_snippets to prevent removing values. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boykoc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wip: Add validator for null form_snippets to prevent removing values. #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ckanext/scheming/plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
scheming_isodatetime_tz,
scheming_valid_json_object,
scheming_load_json,
scheming_do_not_change_if_missing,
)
from ckanext.scheming.logic import (
scheming_dataset_schema_list,
Expand Down Expand Up @@ -140,6 +141,7 @@ def get_validators(self):
'scheming_isodatetime_tz': scheming_isodatetime_tz,
'scheming_valid_json_object': scheming_valid_json_object,
'scheming_load_json': scheming_load_json,
'scheming_do_not_change_if_missing': scheming_do_not_change_if_missing,
}

@run_once_for_caller('_scheming_add_template_directory', lambda: None)
Expand Down
26 changes: 26 additions & 0 deletions ckanext/scheming/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,32 @@ def validator(key, data, errors, context):
return validator


@scheming_validator
def scheming_do_not_change_if_missing(field, schema):
"""
Do not change a value if key is missing.
Default behavior during package_update is to remove value.
"""
def validator(key, data, errors, context):
package = context.get('package')
if package:
original = package.extras.get(key[0], '')
value = data.get(key[0], '')

# May require separate validator for read_only fields
# that are set programatically elsewhere. In which case
# there may not be a need to compare values, just revert
# to original always, not just when empty.
# if original != value:
# data[key] = original

if not value:
# silently replace with the old value when none is sent
data[key] = original

return validator


def scheming_valid_json_object(value, context):
"""Store a JSON object as a serialized JSON string

Expand Down