Merge pull request #489 from ckeditor/epic/ck/18475-eslint9

pomek · web-flow · commit 56585f1c4fe1 · 2025-05-26T13:11:22.000+02:00
Internal: Bumped ESLint to v9.x.

Internal: Bumped Node to v22.x.
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,81 @@
+/**
+ * @license Copyright (c) 2003-2025, CKSource Holding sp. z o.o. All rights reserved.
+ * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
+ */
+
+import globals from 'globals';
+import { defineConfig } from 'eslint/config';
+import ckeditor5Rules from 'eslint-plugin-ckeditor5-rules';
+import ckeditor5Config from 'eslint-config-ckeditor5';
+import tsPlugin from 'typescript-eslint';
+
+export default defineConfig( [
+	{
+		ignores: [
+			'dist/**',
+			'coverage/**',
+			'src/polyfills.ts'
+		]
+	},
+	{
+		extends: ckeditor5Config,
+
+		languageOptions: {
+			ecmaVersion: 'latest',
+			sourceType: 'module'
+		},
+
+		linterOptions: {
+			reportUnusedDisableDirectives: 'warn',
+			reportUnusedInlineConfigs: 'warn'
+		},
+
+		plugins: {
+			'ckeditor5-rules': ckeditor5Rules,
+			'@typescript-eslint': tsPlugin.plugin
+		},
+
+		rules: {
+			'new-cap': 'off',
+			'no-duplicate-imports': 'off',
+			'@typescript-eslint/explicit-function-return-type': 'off',
+			'@typescript-eslint/no-explicit-any': 'off',
+			'@typescript-eslint/no-namespace': 'off',
+			'@typescript-eslint/no-non-null-assertion': 'off',
+			'@typescript-eslint/no-unused-vars': 'error',
+			'@typescript-eslint/no-var-requires': 'off',
+			'@typescript-eslint/no-use-before-define': [ 'error', { functions: false } ],
+			'@stylistic/indent': [ 'error', 'tab' ],
+			'ckeditor5-rules/allow-imports-only-from-main-package-entry-point': 'off',
+			'ckeditor5-rules/prevent-license-key-leak': 'error',
+			'ckeditor5-rules/license-header': [ 'error', {
+				headerLines: [
+					'/**',
+					' * @license Copyright (c) 2003-2025, CKSource Holding sp. z o.o. All rights reserved.',
+					' * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options',
+					' */'
+				]
+			} ]
+		}
+	},
+	{
+		// Disable license header requirement for the entire `src` directory, except the `src/ckeditor` subdirectory.
+		files: [ 'src/**/*' ],
+		ignores: [ 'src/ckeditor/**/*' ],
+		rules: {
+			'ckeditor5-rules/license-header': 'off'
+		}
+	},
+	{
+		files: [
+			'**/*.{js,mjs}',
+			'scripts/**/*.{js,mjs}'
+		],
+
+		languageOptions: {
+			globals: {
+				...globals.node
+			}
+		}
+	}
+] );
diff --git a/karma.conf.js b/karma.conf.js
@@ -6,8 +6,6 @@
 // Karma configuration file, see link for more information
 // https://karma-runner.github.io/1.0/config/configuration-file.html
 
-/* eslint-env node */
-
 module.exports = function( config ) {
 	const karmaConfig = {
 		basePath: '',
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "test:e2e": "cypress run",
     "test:e2e:ci": "start-server-and-test 'yarn run start' http://localhost:4200/ 'yarn run test:e2e --quiet'",
     "coverage": "ng test --watch=false --code-coverage",
-    "lint": "eslint \"*/**/*.+(js|mjs|ts)\"",
+    "lint": "eslint",
     "changelog": "node ./scripts/changelog.mjs",
     "build-package": "ng-packagr -p src/ckeditor/ng-package.json",
     "release:prepare-packages": "node scripts/preparepackages.mjs",
@@ -38,22 +38,22 @@
     "@angular/cli": "^16",
     "@angular/compiler-cli": "^16",
     "@angular/language-service": "^16",
-    "@ckeditor/ckeditor5-dev-bump-year": "^44.0.0",
-    "@ckeditor/ckeditor5-dev-ci": "^44.0.0",
-    "@ckeditor/ckeditor5-dev-release-tools": "^44.0.0",
-    "@ckeditor/ckeditor5-dev-utils": "^44.0.0",
+    "@ckeditor/ckeditor5-dev-bump-year": "^49.0.0",
+    "@ckeditor/ckeditor5-dev-ci": "^49.0.0",
+    "@ckeditor/ckeditor5-dev-release-tools": "^49.0.0",
+    "@ckeditor/ckeditor5-dev-utils": "^49.0.0",
     "@types/jasminewd2": "^2.0.10",
     "@types/node": "^14.11.8",
-    "@typescript-eslint/eslint-plugin": "~5.43.0",
-    "@typescript-eslint/parser": "^5.31.0",
     "ckeditor5": "^44.3.0",
     "ckeditor5-premium-features": "^44.3.0",
     "coveralls": "^3.1.1",
     "css-loader": "^5.2.7",
     "cypress": "^12.17.4",
-    "eslint": "^8.20.0",
-    "eslint-config-ckeditor5": "^7.1.0",
+    "eslint": "^9.26.0",
+    "eslint-config-ckeditor5": "^10.0.0",
+    "eslint-plugin-ckeditor5-rules": "^10.0.0",
     "fs-extra": "^10.0.1",
+    "globals": "^16.1.0",
     "husky": "^8.0.2",
     "jasmine-core": "~3.8.0",
     "jasmine-spec-reporter": "~5.0.0",
@@ -74,6 +74,7 @@
     "ts-loader": "^9.4.3",
     "ts-node": "^9.0.0",
     "typescript": "~5.0.0",
+    "typescript-eslint": "^8.32.0",
     "upath": "^2.0.1",
     "webpack": "^5.94.0",
     "webpack-cli": "^4.10.0"
@@ -83,7 +84,7 @@
     "webpack-dev-middleware": "5.3.4"
   },
   "engines": {
-    "node": ">=20.0.0"
+    "node": ">=22.0.0"
   },
   "author": "CKSource (http://cksource.com/)",
   "license": "SEE LICENSE IN LICENSE.md",
@@ -94,15 +95,8 @@
     "url": "https://github.com/ckeditor/ckeditor5-angular.git"
   },
   "lint-staged": {
-    "**/*.+(js|mjs|ts)": [
+    "**/*": [
       "eslint --quiet"
     ]
-  },
-  "eslintIgnore": [
-    "**/node_modules/**",
-    "**/dist/**",
-    "**/coverage/",
-    "src/polyfills.ts",
-    "ckeditor/**"
-  ]
+  }
 }
diff --git a/scripts/bump-year.mjs b/scripts/bump-year.mjs
@@ -5,8 +5,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 /*
 
 Usage:
@@ -22,7 +20,7 @@ import { bumpYear } from '@ckeditor/ckeditor5-dev-bump-year';
 bumpYear( {
 	cwd: process.cwd(),
 	globPatterns: [
-		{ // LICENSE.md, .eslintrc.js, etc.
+		{
 			pattern: '*',
 			options: {
 				dot: true
diff --git a/scripts/changelog.mjs b/scripts/changelog.mjs
@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 import { generateChangelogForSinglePackage } from '@ckeditor/ckeditor5-dev-release-tools';
 import parseArguments from './utils/parsearguments.mjs';
 
diff --git a/scripts/ci/is-project-ready-to-release.mjs b/scripts/ci/is-project-ready-to-release.mjs
@@ -5,8 +5,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 import { createRequire } from 'module';
 import * as releaseTools from '@ckeditor/ckeditor5-dev-release-tools';
 
diff --git a/scripts/postinstall.js b/scripts/postinstall.js
@@ -5,8 +5,6 @@
 
 'use strict';
 
-/* eslint-env node */
-
 const path = require( 'path' );
 const fs = require( 'fs' );
 const ROOT_DIRECTORY = path.join( __dirname, '..' );
diff --git a/scripts/preparepackages.mjs b/scripts/preparepackages.mjs
@@ -5,8 +5,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 import fs from 'fs-extra';
 import upath from 'upath';
 import { Listr } from 'listr2';
@@ -102,6 +100,10 @@ const tasks = new Listr( [
 				packageJson => {
 					packageJson.version = latestVersion;
 
+					if ( packageJson.engines ) {
+						delete packageJson.engines;
+					}
+
 					return packageJson;
 				} );
 		},
diff --git a/scripts/publishpackages.mjs b/scripts/publishpackages.mjs
@@ -5,8 +5,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 import { Listr } from 'listr2';
 import * as releaseTools from '@ckeditor/ckeditor5-dev-release-tools';
 import parseArguments from './utils/parsearguments.mjs';
diff --git a/scripts/utils/getlistroptions.mjs b/scripts/utils/getlistroptions.mjs
@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 /**
  * @param {ReleaseOptions} cliArguments
  * @returns {Object}
diff --git a/scripts/utils/parsearguments.mjs b/scripts/utils/parsearguments.mjs
@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* eslint-env node */
-
 import minimist from 'minimist';
 
 /**
diff --git a/src/app/context-demo/context-demo.ts b/src/app/context-demo/context-demo.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, ViewChild } from '@angular/core';
+import { Component, ViewChild, type ElementRef } from '@angular/core';
 
 import { AngularEditor } from 'src/editor/editor';
 import { CKEditorComponent } from '../../ckeditor/ckeditor.component';
diff --git a/src/app/demo-form/demo-form.component.ts b/src/app/demo-form/demo-form.component.ts
@@ -1,6 +1,5 @@
 import { Component, ViewChild, type AfterViewInit } from '@angular/core';
-import { NgForm } from '@angular/forms';
-import type { AbstractControl } from '@angular/forms';
+import type { AbstractControl, NgForm } from '@angular/forms';
 
 import { AngularEditor } from 'src/editor/editor';
 
diff --git a/src/ckeditor/ckeditor.component.spec.ts b/src/ckeditor/ckeditor.component.spec.ts
@@ -631,7 +631,6 @@ describe( 'change detection', () => {
 
 			@ViewChild( CKEditorComponent, { static: true } ) public ckEditorComponent!: CKEditorComponent;
 
-			// eslint-disable-next-line @typescript-eslint/no-empty-function
 			public onError(): void {}
 		}
 
diff --git a/src/ckeditor/ckeditor.component.ts b/src/ckeditor/ckeditor.component.ts
diff --git a/src/editor/mock-editor.ts b/src/editor/mock-editor.ts
diff --git a/src/test.ts b/src/test.ts
diff --git a/yarn.lock b/yarn.lock
