Merge pull request #19416 from ckeditor/cc/8549-internal-reexp

Extending export validator to disallow re-exporting internal entities in commercial repo.

Author: arkflpc

scripts/ci/exports/utils/library.mjs

@@ -22,11 +22,12 @@ export class Library {
 		this.modules = typeScriptFileNames.map( fileName => Module.load( fileName, this.errorCollector ) );
 
 		for ( const module of this.modules ) {
-			const packageName = module.packageName;
+			const { packageName, isPublicPackage } = module;
 
 			if ( !this.packages.has( packageName ) ) {
 				this.packages.set( packageName, {
 					packageName,
+					isPublicPackage,
 					dirName: packageDirName( module.fileName ),
 					index: null,
 					modules: []

scripts/ci/exports/utils/module.mjs

@@ -42,7 +42,8 @@ export class Module {
 
 	constructor( fileName, ast, { publicApiTag }, errorCollector ) {
 		this.fileName = fileName.replace( /\.d\.ts$/, '.ts' );
-		this.isPublicApi = this._isFromPublicPackages( fileName ) || this.relativeFileName === 'index.ts' ? true : publicApiTag;
+		this.isPublicPackage = this._isFromPublicPackages( fileName );
+		this.isPublicApi = this.isPublicPackage || this.relativeFileName === 'index.ts' ? true : publicApiTag;
 		this.exports = [];
 		this.imports = [];
 		this.declarations = [];

scripts/ci/validate-module-re-exports.mjs

@@ -140,6 +140,10 @@ function getFixingAction( pkg, module, exportItem ) {
 		return 'Add @internal and re-export with `_` suffix';
 	}
 
+	if ( isInternal && isReExported && !allowsReexportInternals( pkg ) ) {
+		return 'Remove from index or @internal.';
+	}
+
 	const namingCheck = validateNaming( { pkg, module, item: exportItem } );
 
 	if ( !namingCheck.ok ) {
@@ -176,3 +180,7 @@ function removeExpectedExceptions( data ) {
 		.filter( record => !memberExistInRecord( record, '@ckeditor/ckeditor5-find-and-replace', 'FindReplaceCommandBase' ) )
 		.filter( record => !memberExistInRecord( record, '@ckeditor/ckeditor5-utils', 'globalVar' ) );
 }
+
+function allowsReexportInternals( pkg ) {
+	return pkg.isPublicPackage;
+}