C++: Add 'mremap' to whitelist.

geoffw0 · geoffw0 · commit 059864587e7e · 2022-10-10T11:00:18.000+01:00
diff --git a/cpp/ql/src/Security/CWE/CWE-121/UnterminatedVarargsCall.ql b/cpp/ql/src/Security/CWE/CWE-121/UnterminatedVarargsCall.ql
@@ -67,11 +67,7 @@ class VarargsFunction extends Function {
     not exists(FunctionCall fc, int index | this.nonTrailingVarArgValue(fc, index) = result)
   }
 
-  predicate isWhitelisted() {
-    this.hasGlobalName("open") or
-    this.hasGlobalName("fcntl") or
-    this.hasGlobalName("ptrace")
-  }
+  predicate isWhitelisted() { this.hasGlobalName(["open", "fcntl", "ptrace", "mremap"]) }
 }
 
 from VarargsFunction f, FunctionCall fc, string terminator, int cnt, int totalCount

Original file line number	Diff line number	Diff line change
`@@ -67,11 +67,7 @@ class VarargsFunction extends Function {`
`67`	`67`	`not exists(FunctionCall fc, int index \| this.nonTrailingVarArgValue(fc, index) = result)`
`68`	`68`	`}`
`69`	`69`
`70`		`- predicate isWhitelisted() {`
`71`		`- this.hasGlobalName("open") or`
`72`		`- this.hasGlobalName("fcntl") or`
`73`		`- this.hasGlobalName("ptrace")`
`74`		`- }`
	`70`	`+ predicate isWhitelisted() { this.hasGlobalName(["open", "fcntl", "ptrace", "mremap"]) }`
`75`	`71`	`}`
`76`	`72`
`77`	`73`	`from VarargsFunction f, FunctionCall fc, string terminator, int cnt, int totalCount`