Skip to content

Commit 0bf0e0e

Browse files
committed
Revert "Ruby: Fix performance for argumentPositionMatch"
as requested to use a different performance fix and Revert "Dataflow: Sync `DataFlowImplCommon`" This reverts commit c9a833f This reverts commit 911ddb9.
1 parent ae65af2 commit 0bf0e0e

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ predicate accessPathCostLimits(int apLimit, int tupleLimit) {
8080
pragma[noinline]
8181
predicate argumentPositionMatch(DataFlowCall call, ArgNode arg, ParameterPosition ppos) {
8282
exists(ArgumentPosition apos |
83-
arg.argumentOf(call, pragma[only_bind_into](apos)) and
84-
parameterMatch(ppos, pragma[only_bind_into](apos))
83+
arg.argumentOf(call, apos) and
84+
parameterMatch(ppos, apos)
8585
)
8686
}
8787

0 commit comments

Comments
 (0)