Skip to content

Commit 0e0f159

Browse files
committed
Python: Use Python 3 for investigation tests
Apparently there are minor differences with `test-6-max-import-depth-2` where under Python 2 `isfile_no_problem.py` still works as before
1 parent 01d426d commit 0e0f159

File tree

7 files changed

+7
-7
lines changed
  • python/ql/test/experimental/dataflow/strange-pointsto-interaction-investigation

7 files changed

+7
-7
lines changed

python/ql/test/experimental/dataflow/strange-pointsto-interaction-investigation/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ $ diff -u -r test-4-max-import-depth-100/ test-5-max-import-depth-3/
8181
+semmle-extractor-options: --max-import-depth=3 -R ../src
8282
```
8383

84-
Also notice that using import depth 2 actually makes things worse, as we no longer handle the `isfile_no_problem.py` file properly :facepalm: :sweat_smile:
84+
Also notice that using import depth 2 actually makes things worse, as we no longer handle the `isfile_no_problem.py` file properly :facepalm: :sweat_smile: NOTE: This was only for Python 3, for Python 2 there was no change :flushed:
8585

8686
```diff
8787
diff '--color=auto' -u -r test-4-max-import-depth-100/NormalDataflowTest.expected test-6-max-import-depth-2/NormalDataflowTest.expected
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --max-import-depth=1 -R ../src
1+
semmle-extractor-options: --lang=3 --max-import-depth=1 -R ../src
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --dont-split-graph --max-import-depth=1 -R ../src
1+
semmle-extractor-options: --lang=3 --dont-split-graph --max-import-depth=1 -R ../src
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --max-import-depth=0 -R ../src
1+
semmle-extractor-options: --lang=3 --max-import-depth=0 -R ../src
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --max-import-depth=100 -R ../src
1+
semmle-extractor-options: --lang=3 --max-import-depth=100 -R ../src
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --max-import-depth=3 -R ../src
1+
semmle-extractor-options: --lang=3 --max-import-depth=3 -R ../src
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --max-import-depth=2 -R ../src
1+
semmle-extractor-options: --lang=3 --max-import-depth=2 -R ../src

0 commit comments

Comments
 (0)