JS: Include a local step before store step

asgerf · asgerf · commit 0fb79bdf64c5 · 2023-04-27T17:58:02.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Express.qll b/javascript/ql/lib/semmle/javascript/frameworks/Express.qll
@@ -216,7 +216,8 @@ module Express {
         Http::routeHandlerStep(result, succ) and
         t = t2
         or
-        DataFlow::SharedFlowStep::storeStep(result, succ, DataFlow::PseudoProperties::arrayElement()) and
+        DataFlow::SharedFlowStep::storeStep(result.getALocalUse(), succ,
+          DataFlow::PseudoProperties::arrayElement()) and
         t = t2.continue()
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,8 @@ module Express {`
`216`	`216`	`Http::routeHandlerStep(result, succ) and`
`217`	`217`	`t = t2`
`218`	`218`	`or`
`219`		`- DataFlow::SharedFlowStep::storeStep(result, succ, DataFlow::PseudoProperties::arrayElement()) and`
	`219`	`+ DataFlow::SharedFlowStep::storeStep(result.getALocalUse(), succ,`
	`220`	`+ DataFlow::PseudoProperties::arrayElement()) and`
`220`	`221`	`t = t2.continue()`
`221`	`222`	`)`
`222`	`223`	`}`