Swift: DataFlow expr and parameter nodes

Author: rdmarsh2

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll

@@ -1,6 +1,7 @@
 private import swift
 private import DataFlowPublic
 private import DataFlowDispatch
+private import codeql.swift.controlflow.CfgNodes
 
 /** Gets the callable in which this node occurs. */
 DataFlowCallable nodeGetEnclosingCallable(NodeImpl n) { result = n.getEnclosingCallable() }
@@ -25,11 +26,19 @@ abstract class NodeImpl extends Node {
   abstract string toStringImpl();
 }
 
+private class ExprNodeImpl extends ExprNode, NodeImpl {
+  override Location getLocationImpl() { result = expr.getLocation() }
+
+  override string toStringImpl() { result = expr.toString() }
+}
+
 /** A collection of cached types and predicates to be evaluated in the same stage. */
 cached
 private module Cached {
   cached
-  newtype TNode = TODO_TNode()
+  newtype TNode =
+    TExprNode(ExprCfgNode e) or
+    TNormalParameterNode(ParamDecl p)
 
   /**
    * This is the local flow predicate that is used as a building block in global
@@ -58,6 +67,20 @@ private module ParameterNodes {
   abstract class ParameterNodeImpl extends NodeImpl {
     predicate isParameterOf(DataFlowCallable c, ParameterPosition pos) { none() }
   }
+
+  class NormalParameterNode extends ParameterNodeImpl, TNormalParameterNode {
+    ParamDecl param;
+
+    NormalParameterNode() { this = TNormalParameterNode(param) }
+
+    override Location getLocationImpl() { result = param.getLocation() }
+
+    override string toStringImpl() { result = param.toString() }
+
+    override predicate isParameterOf(DataFlowCallable c, ParameterPosition pos) {
+      none() // TODO
+    }
+  }
 }
 
 import ParameterNodes
@@ -173,7 +196,9 @@ class Unit extends TUnit {
  */
 predicate isUnreachableInCall(Node n, DataFlowCall call) { none() }
 
-newtype LambdaCallKind = TODO_TLambdaCallKind()
+newtype LambdaCallKind =
+  TYieldCallKind() or
+  TLambdaCallKind()
 
 /** Holds if `creation` is an expression that creates a lambda of kind `kind` for `c`. */
 predicate lambdaCreation(Node creation, LambdaCallKind kind, DataFlowCallable c) { none() }

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPublic.qll

@@ -3,6 +3,7 @@ private import DataFlowDispatch
 private import DataFlowPrivate
 private import codeql.swift.controlflow.ControlFlowGraph
 private import codeql.swift.controlflow.BasicBlocks
+private import codeql.swift.controlflow.CfgNodes
 
 /**
  * An element, viewed as a node in a data flow graph. Either an expression
@@ -38,7 +39,11 @@ class Node extends TNode {
  * to multiple `ExprNode`s, just like it may correspond to multiple
  * `ControlFlow::Node`s.
  */
-class ExprNode extends Node { }
+class ExprNode extends Node { 
+  ExprCfgNode expr;
+
+  ExprNode() { this = TExprNode(expr) }
+}
 
 /**
  * The value of a parameter at function entry, viewed as a node in a data